From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: IRQF_RESUME_EARLY and errors in dpm_suspend_noirq Date: Wed, 20 Nov 2013 15:24:10 +0530 Message-ID: <528C86C2.1070206@nvidia.com> References: <201311201020.08158.heiko@sntech.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from hqemgate15.nvidia.com ([216.228.121.64]:2075 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858Ab3KTJz5 convert rfc822-to-8bit (ORCPT ); Wed, 20 Nov 2013 04:55:57 -0500 In-Reply-To: <201311201020.08158.heiko@sntech.de> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: =?ISO-8859-1?Q?Heiko_St=FCbner?= Cc: Ian Campbell , "Rafael J. Wysocki" , Thomas Gleixner , Len Brown , Greg Kroah-Hartman , Pavel Machek , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" On Wednesday 20 November 2013 02:50 PM, Heiko St=FCbner wrote: > Hi, > > Commit 9bab0b7fbace (genirq: Add IRQF_RESUME_EARLY and resume such IR= Qs > earlier) split the suspend/resume of the irqs into two parts. > > The early-irqs get resumed during syscore_resume, while the rest get > resumed by the regular resume_device_irqs. > > I may be blind, but where get the early-irqs resumed in the error > path of dpm_suspend_noirq? > > When a suspend_noirq callback returns an error, dpm_resume_noirq gets= called, > which only calls resume_device_irqs while the suspend_device_irqs cal= l in > dpm_suspend_noirq suspends all irqs. So it does not seem that the ear= ly-irqs > get resumed at all in this case. > I also faced same issue in our suspend failure path and posted fix=20 sometime ago as https://lkml.org/lkml/2013/8/13/373 It is still under review. You can try this patch if it resolve the issue. Thanks, Laxman