From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh kumar Subject: Re: [PATCH] cpufreq: Make sure CPU is running on a freq from freq-table Date: Fri, 22 Nov 2013 12:36:06 +0530 Message-ID: <528F025E.70202@linaro.org> References: <528E4950.9030507@gmail.com> <1980582.Pd2pT79ZWp@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-qe0-f52.google.com ([209.85.128.52]:65399 "EHLO mail-qe0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750975Ab3KVHGO (ORCPT ); Fri, 22 Nov 2013 02:06:14 -0500 Received: by mail-qe0-f52.google.com with SMTP id ne12so647668qeb.39 for ; Thu, 21 Nov 2013 23:06:14 -0800 (PST) In-Reply-To: <1980582.Pd2pT79ZWp@vostro.rjw.lan> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "Rafael J. Wysocki" , Dirk Brandewie Cc: Nishanth Menon , Lists linaro-kernel , Patch Tracking , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , Shawn Guo , Sripa Bagadia On Friday 22 November 2013 03:13 AM, Rafael J. Wysocki wrote: > On Thursday, November 21, 2013 09:56:32 AM Dirk Brandewie wrote: >> The scaling driver for the CPU has already loaded and its .init procedure has >> been called so .target better be callable. Yeah.. >> Since the scaling driver is responsible maintaining the set of valid frequencies >> and setting policy->cur I think it is reasonable to have the scaling driver >> ensure that policy->cur returned from its .init I agree.. >> and the operating frequency are >> in sync and match one of the values in its frequency table. Hmmm, that doesn't necessarily lie in driver's domain but maybe at a common place like core. That's why we had this patch.. > From that I infer that we should not continue on errors here. Which also is my > opinion. Okay.. Code modified to return error on failure.. Will send V2 as soon as patch is tested by Nishanth..