From: Lan Tianyu <tianyu.lan@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
hg197@gmx.de, "cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Cpufreq: Change sysfs interface cpuinfo_cur_freq access privilege
Date: Mon, 25 Nov 2013 19:55:33 +0800 [thread overview]
Message-ID: <52933AB5.9060409@intel.com> (raw)
In-Reply-To: <5074010.ha99UACE9S@vostro.rjw.lan>
On 11/25/2013 07:26 PM, Rafael J. Wysocki wrote:
> On Monday, November 25, 2013 01:33:39 PM Lan Tianyu wrote:
>> On 2013年11月25日 12:30, Viresh Kumar wrote:
>>> On 25 November 2013 08:23, Lan Tianyu <tianyu.lan@intel.com> wrote:
>>>> Currently, cpuinfo_cur_freq is only accessible for root user while
>>>> other cpufreq sysfs interfaces(E,G scaling_cur_freq) are available
>>>> to ordinary user. This seems make no sense. This patch is to change
>>>> it.
>>>
>>> There is nothing wrong with the code and so this is more of a design
>>> change..
>>>
>>> Probably Rafael can help us here as cpufreq_cur_freq will read stuff
>>> directly from hardware instead of using cached value in software.
>>
>> I think so, too. I also tried to checking the reason of the privilege by
>> git log but the code was there before linux kernel being migrated to git
>> repository.
>
> And it has always behaved in the same way? Then I wouldn't change it.
>
It has been there since 2.6.12-rc2 or more early. But the
cpuinfo_cur_freq is read-only and seems no harmful.
Request from bug 65611.
https://bugzilla.kernel.org/show_bug.cgi?id=65611.
> Thanks!
>
--
Best Regards
Tianyu Lan
next prev parent reply other threads:[~2013-11-25 11:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 2:53 [PATCH] Cpufreq: Change sysfs interface cpuinfo_cur_freq access privilege Lan Tianyu
2013-11-25 4:30 ` Viresh Kumar
2013-11-25 5:33 ` Lan Tianyu
2013-11-25 11:26 ` Rafael J. Wysocki
2013-11-25 11:55 ` Lan Tianyu [this message]
2013-11-25 12:14 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52933AB5.9060409@intel.com \
--to=tianyu.lan@intel.com \
--cc=cpufreq@vger.kernel.org \
--cc=hg197@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).