From: Nishanth Menon <nm@ti.com>
To: Viresh Kumar <viresh.kumar@linaro.org>, rjw@rjwysocki.net
Cc: linaro-kernel@lists.linaro.org, patches@linaro.org,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, tianyu.lan@intel.com,
jinchoi@broadcom.com, sebastian.capella@linaro.org
Subject: Re: [PATCH V2 1/2] cpufreq: suspend governors on system suspend/hibernate
Date: Mon, 25 Nov 2013 15:30:21 -0600 [thread overview]
Message-ID: <5293C16D.80605@ti.com> (raw)
In-Reply-To: <e4bc55fac6bc68694e9905cc3cc6844173b64925.1385118256.git.viresh.kumar@linaro.org>
On 11/22/2013 05:29 AM, Viresh Kumar wrote:
> This patch adds cpufreq callbacks to dpm_{suspend|resume}_noirq() for handling
> suspend/resume of cpufreq governors. This is required for early suspend and late
> resume of governors.
>
> There are multiple problems that are fixed by this patch:
> - Nishanth Menon (TI) found an interesting problem on his platform, OMAP. His board
> wasn't working well with suspend/resume as calls for removing non-boot CPUs
> was turning out into a call to drivers ->target() which then tries to play
> with regulators. But regulators and their I2C bus were already suspended and
> this resulted in a failure. This is why we need a PM notifier here.
> - Lan Tianyu (Intel) & Jinhyuk Choi (Broadcom) found another issue where
> tunables configuration for clusters/sockets with non-boot CPUs was getting
> lost after suspend/resume, as we were notifying governors with
> CPUFREQ_GOV_POLICY_EXIT on removal of the last cpu for that policy and so
> deallocating memory for tunables.
>
> Reported-by: Lan Tianyu <tianyu.lan@intel.com>
> Reported-by: Nishanth Menon <nm@ti.com>
> Reported-by: Jinhyuk Choi <jinchoi@broadcom.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/base/power/main.c | 3 +++
> drivers/cpufreq/cpufreq.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++
> include/linux/cpufreq.h | 3 +++
> 3 files changed, 68 insertions(+)
yes, this seems to work for me as well.
http://pastebin.mozilla.org/3670909 - no cpufreq attempts to
transition were triggered.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-11-25 21:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 11:29 [PATCH V2 0/2] cpufreq: suspend governors during s2r/hibernation Viresh Kumar
2013-11-22 11:29 ` [PATCH V2 1/2] cpufreq: suspend governors on system suspend/hibernate Viresh Kumar
2013-11-22 12:33 ` Rafael J. Wysocki
2013-11-22 12:48 ` Viresh Kumar
2013-11-25 21:30 ` Nishanth Menon [this message]
2013-11-26 2:16 ` Viresh Kumar
2013-11-26 19:39 ` Pavel Machek
2013-11-26 20:18 ` Rafael J. Wysocki
2013-11-27 2:56 ` Viresh Kumar
2013-11-27 14:26 ` Rafael J. Wysocki
2013-11-22 11:29 ` [PATCH V2 2/2] cpufreq: Change freq before suspending governors Viresh Kumar
2013-11-22 12:37 ` Rafael J. Wysocki
2013-11-22 12:52 ` Viresh Kumar
2013-11-22 13:25 ` Rafael J. Wysocki
2013-11-22 13:14 ` Viresh Kumar
2013-11-22 19:39 ` Stephen Warren
2013-11-24 21:32 ` Rafael J. Wysocki
2013-11-25 4:28 ` Viresh Kumar
2013-11-25 10:14 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5293C16D.80605@ti.com \
--to=nm@ti.com \
--cc=cpufreq@vger.kernel.org \
--cc=jinchoi@broadcom.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@rjwysocki.net \
--cc=sebastian.capella@linaro.org \
--cc=tianyu.lan@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).