From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lan Tianyu Subject: Re: [PATCH V3 1/6] cpufreq: suspend governors on system suspend/hibernate Date: Wed, 27 Nov 2013 15:08:36 +0800 Message-ID: <52959A74.70007@intel.com> References: <4253729.doK7ubnxKx@vostro.rjw.lan> <4787675.sJF8mqYyxv@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mga02.intel.com ([134.134.136.20]:43962 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750842Ab3K0HUN (ORCPT ); Wed, 27 Nov 2013 02:20:13 -0500 In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Viresh Kumar Cc: "Rafael J. Wysocki" , Lists linaro-kernel , Patch Tracking , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , Nishanth Menon , Stephen Warren , Kgene Kim , linux-samsung-soc , linux-tegra@vger.kernel.org, jinchoi@broadcom.com, Sebastian Capella , Jonghwan Choi On 2013=E5=B9=B411=E6=9C=8827=E6=97=A5 11:07, Viresh Kumar wrote: > On 27 November 2013 07:12, Rafael J. Wysocki wrot= e: >> Anyway, if you did what I asked you to do and put the cpufreq suspen= d/resume >> into dpm_suspend/resume_noirq(), I'd probably take this for 3.13. H= owever, >> since you've decided to put those things somewhere else thus making = the >> change much more intrusive, I can only queue it up for 3.14. >> >> This means I'm going to take the Tianyu's patch as a stop gap for 3.= 13. >=20 Hi Viresh: First, I agree the new solution you are working on. :) But actually I don't totally agree my origin patch have design issue. Because I think governor should have the ability to check whether it ha= s been EXIT when doing INIT and it should return error code at that point= =2E The design is to make governor code stronger to deal with the case that governor is reinitialized before EXIT. Just from my view. Sorry for noise. > There were design issues with that patch actually, as I pointed out e= arlier > (handling EXIT part in core and INIT in governors).. And so in case w= e > need to get something for v3.13, I will send a short version of this = series > with callbacks from suspend_noirq. >=20 > Get that one instead. >=20 > -- > viresh >=20 --=20 Best regards Tianyu Lan