From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Lan Tianyu <lantianyu1986@gmail.com>, ziegler@uni-freiburg.de
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
"viresh kumar" <viresh.kumar@linaro.org>,
"Bjørn Mork" <bjorn@mork.no>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"Linux PM list" <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH] cpufreq: fix garbage kobj on errors during suspend/resume
Date: Mon, 09 Dec 2013 12:18:06 +0530 [thread overview]
Message-ID: <52A567A6.6000400@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAOLK0pxW_AjtGNwW2G8-1SpJbYs_GWQDLV=7XzPfDHRj6tCxQQ@mail.gmail.com>
On 12/09/2013 08:29 AM, Lan Tianyu wrote:
> 2013/12/5 Rafael J. Wysocki <rjw@rjwysocki.net>:
>> On Wednesday, December 04, 2013 04:02:18 PM viresh kumar wrote:
>>> On Tuesday 03 December 2013 04:44 PM, Bjørn Mork wrote:
>>>> This is effectively a revert of commit 5302c3fb2e62 ("cpufreq: Perform
>>>> light-weight init/teardown during suspend/resume"), which enabled
>>>> suspend/resume optimizations leaving the sysfs files in place.
[...]
>> I took the Bjorn's patch for 3.13 and this one I can queued up for 3.14,
>> but for that I guess it should contain a revert of the change made by the
>> Bjorn's patch.
>
> This patch causes a s3 regression. Cc:Martin Ziegler
> https://bugzilla.kernel.org/show_bug.cgi?id=66751
>
Hmm.. With Bjorn's patch applied, the cpufreq hotplug callback should become
identical to what happens during regular CPU hotplug. So is regular CPU
hotplug also failing for you, Martin?
You can do CPU hotplug by:
CPU offline:
echo 0 > /sys/devices/system/cpu/cpu<num>/online
CPU online:
echo 1 > /sys/devices/system/cpu/cpu<num>/online
Bjorn's patch looks pretty innocuous to me.. I couldn't catch any obvious
bug looking at the code. So answer to the above question should help us dig
deeper.
Regards,
Srivatsa S. Bhat
next prev parent reply other threads:[~2013-12-09 6:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 11:14 [PATCH] cpufreq: fix garbage kobj on errors during suspend/resume Bjørn Mork
2013-12-03 21:45 ` Rafael J. Wysocki
2013-12-04 6:23 ` Srivatsa S. Bhat
2013-12-24 9:46 ` Jarzmik, Robert
2013-12-04 10:32 ` viresh kumar
2013-12-04 12:08 ` Bjørn Mork
2013-12-04 14:41 ` Viresh Kumar
2013-12-04 15:41 ` Bjørn Mork
[not found] ` <CAKohponu3Fu=WaBHXP1iBJM87V9g=+hDPe=M168U_weODenZdQ@mail.gmail.com>
[not found] ` <878uvzyecg.fsf@nemi.mork.no>
2013-12-05 12:41 ` Srivatsa S. Bhat
2013-12-05 13:21 ` Bjørn Mork
2013-12-05 22:29 ` Rafael J. Wysocki
2013-12-06 5:23 ` Srivatsa S. Bhat
2013-12-07 1:17 ` Rafael J. Wysocki
2013-12-05 1:29 ` Rafael J. Wysocki
2013-12-09 2:59 ` Lan Tianyu
2013-12-09 6:48 ` Srivatsa S. Bhat [this message]
2013-12-09 10:04 ` Bjørn Mork
2013-12-12 1:59 ` Rafael J. Wysocki
2013-12-12 8:52 ` Bjørn Mork
2013-12-09 11:24 ` Martin Ziegler
2013-12-09 11:53 ` Bjørn Mork
2013-12-10 16:02 ` Martin Ziegler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A567A6.6000400@linux.vnet.ibm.com \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=bjorn@mork.no \
--cc=cpufreq@vger.kernel.org \
--cc=lantianyu1986@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
--cc=ziegler@uni-freiburg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).