From: Stephen Warren <swarren@wwwdotorg.org>
To: Bill Huang <bilhuang@nvidia.com>,
rjw@rjwysocki.net, viresh.kumar@linaro.org,
thierry.reding@gmail.com
Cc: linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org,
linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v5 1/1] cpufreq: tegra: Re-model Tegra20 cpufreq driver
Date: Thu, 19 Dec 2013 12:33:35 -0700 [thread overview]
Message-ID: <52B34A0F.5080901@wwwdotorg.org> (raw)
In-Reply-To: <1387451926-21373-1-git-send-email-bilhuang@nvidia.com>
On 12/19/2013 04:18 AM, Bill Huang wrote:
> Re-model Tegra20 cpufreq driver as below.
>
> * Rename tegra-cpufreq.c to tegra20-cpufreq.c since this file supports
> only Tegra20.
> * Add probe function so defer probe can be used when we're going to
> support DVFS.
> * Create a fake cpufreq platform device with its name being
> "${root_compatible}-cpufreq" so SoC cpufreq driver can bind to it
> accordingly.
Tested-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
It should be fine to merge the arch/arm/mach-tegra/ changes in this
patch through the cpufreq tree, since I don't think they'll conflict at
all with anything in other trees this kernel cycle.
> diff --git a/drivers/cpufreq/tegra-cpufreq.c b/drivers/cpufreq/tegra20-cpufreq.c
> -#define NUM_CPUS 2
> +#define MAX_CPUS 2
Nit: Given this driver is explicitly for a 2-CPU SoC, I don't think
there's any need to s/NUM/MAX/ here. But I don't care that much.
next prev parent reply other threads:[~2013-12-19 19:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 11:18 [PATCH v5 1/1] cpufreq: tegra: Re-model Tegra20 cpufreq driver Bill Huang
2013-12-19 19:33 ` Stephen Warren [this message]
2013-12-20 9:31 ` Viresh Kumar
2013-12-20 10:25 ` bilhuang
2013-12-20 10:33 ` Viresh Kumar
2013-12-20 10:42 ` bilhuang
2013-12-20 16:29 ` Stephen Warren
2013-12-23 5:06 ` Viresh Kumar
2014-01-02 11:08 ` bilhuang
2014-01-03 5:47 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B34A0F.5080901@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=bilhuang@nvidia.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).