From: Stephen Warren <swarren@wwwdotorg.org>
To: bilhuang <bilhuang@nvidia.com>, Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Thierry Reding <thierry.reding@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v5 1/1] cpufreq: tegra: Re-model Tegra20 cpufreq driver
Date: Fri, 20 Dec 2013 09:29:51 -0700 [thread overview]
Message-ID: <52B4707F.4040303@wwwdotorg.org> (raw)
In-Reply-To: <52B41F1B.3030005@nvidia.com>
On 12/20/2013 03:42 AM, bilhuang wrote:
> On 12/20/2013 06:33 PM, Viresh Kumar wrote:
>> On 20 December 2013 15:55, bilhuang <bilhuang@nvidia.com> wrote:
>>> Don't you think it worth creating a file here so this can be shared to
>>> arm64?
>>
>> We will see how to handle virtual devices when we will start getting
>> arm64 SoCs. Probably we might end up writing a single file in cpufreq,
>> if required, that will create virtual devices for every arm64 platform..
>>
>> So, some people might use it and others wouldn't.. But no platform
>> specific files for such stuff. So, the best we can do for now is to move
>> these to platform code as we are talking about arm32 SoC's for now
>> which do have a mach-* directory..
>>
> OK thanks, this is suggested by Stephen earlier, I'll let him comment in
> case he might think otherwise.
No, I definitely don't agree here. The rules for arch/arm64 are: no
platform-specific code. We should immediately start planning for that.
If this means renaming the file that creates the virtual device from
tegra-cpufreq.c to something else, so be it, but we shouldn't go
backwards and push stuff into the arch directories.
next prev parent reply other threads:[~2013-12-20 16:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 11:18 [PATCH v5 1/1] cpufreq: tegra: Re-model Tegra20 cpufreq driver Bill Huang
2013-12-19 19:33 ` Stephen Warren
2013-12-20 9:31 ` Viresh Kumar
2013-12-20 10:25 ` bilhuang
2013-12-20 10:33 ` Viresh Kumar
2013-12-20 10:42 ` bilhuang
2013-12-20 16:29 ` Stephen Warren [this message]
2013-12-23 5:06 ` Viresh Kumar
2014-01-02 11:08 ` bilhuang
2014-01-03 5:47 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B4707F.4040303@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=bilhuang@nvidia.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).