From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad Date: Sat, 04 Jan 2014 09:35:58 +0100 Message-ID: <52C7C7EE.1070407@redhat.com> References: <52C6F3B4.3050904@gmail.com> <20140103180435.GK10961@minantech.com> <2513222.AheLcigoE8@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2513222.AheLcigoE8@vostro.rjw.lan> Sender: cpufreq-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: Gleb Natapov , Dirk Brandewie , Kashyap Chamarthy , Josh Boyer , One Thousand Gnomes , Viresh Kumar , "cpufreq@vger.kernel.org" , Linux PM list , "Linux-Kernel@Vger. Kernel. Org" , "Richard W.M. Jones" List-Id: linux-pm@vger.kernel.org Il 03/01/2014 23:46, Rafael J. Wysocki ha scritto: > Well, fixing the KVM bug is surely welcome. > > That said, adding checks to ensure that your assumptions are valid is rarely > wrong, especially if they are done once per kernel boot. And the kernel only > should panic if it cannot continue to run, which isn't the case here. I agree, but I suspect even your check is already late. Your patch is welcome but perhaps it should have a WARN_ON too. Paolo