linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] hwmon: Fix SENSORS_TMP102 dependencies to eliminate build errors
@ 2014-01-08  7:05 Jean Delvare
  2014-01-08 12:20 ` Eduardo Valentin
  2014-01-08 13:49 ` Guenter Roeck
  0 siblings, 2 replies; 3+ messages in thread
From: Jean Delvare @ 2014-01-08  7:05 UTC (permalink / raw)
  To: Eduardo Valentin, Zhang Rui
  Cc: LM Sensors, linux-pm, Randy Dunlap, Guenter Roeck

Similar to what was done for the lm75 driver.

Add depends on THERMAL since that is what provides the
register/unregister functions above, but only if THERMAL_OF was
selected as this is an optional feature of the driver.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Eduardo Valentin <eduardo.valentin@ti.com>
---
 drivers/hwmon/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-3.13-rc7.orig/drivers/hwmon/Kconfig	2014-01-08 08:00:58.583072658 +0100
+++ linux-3.13-rc7/drivers/hwmon/Kconfig	2014-01-08 08:01:36.928977997 +0100
@@ -1285,6 +1285,7 @@ config SENSORS_THMC50
 config SENSORS_TMP102
 	tristate "Texas Instruments TMP102"
 	depends on I2C
+	depends on THERMAL || !THERMAL_OF
 	help
 	  If you say yes here you get support for Texas Instruments TMP102
 	  sensor chips.


-- 
Jean Delvare

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] hwmon: Fix SENSORS_TMP102 dependencies to eliminate build errors
  2014-01-08  7:05 [PATCH] hwmon: Fix SENSORS_TMP102 dependencies to eliminate build errors Jean Delvare
@ 2014-01-08 12:20 ` Eduardo Valentin
  2014-01-08 13:49 ` Guenter Roeck
  1 sibling, 0 replies; 3+ messages in thread
From: Eduardo Valentin @ 2014-01-08 12:20 UTC (permalink / raw)
  To: Jean Delvare
  Cc: Eduardo Valentin, Zhang Rui, LM Sensors, linux-pm, Randy Dunlap,
	Guenter Roeck

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]

On 08-01-2014 03:05, Jean Delvare wrote:
> Similar to what was done for the lm75 driver.
> 
> Add depends on THERMAL since that is what provides the
> register/unregister functions above, but only if THERMAL_OF was
> selected as this is an optional feature of the driver.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: Eduardo Valentin <eduardo.valentin@ti.com>

Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>

> ---
>  drivers/hwmon/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-3.13-rc7.orig/drivers/hwmon/Kconfig	2014-01-08 08:00:58.583072658 +0100
> +++ linux-3.13-rc7/drivers/hwmon/Kconfig	2014-01-08 08:01:36.928977997 +0100
> @@ -1285,6 +1285,7 @@ config SENSORS_THMC50
>  config SENSORS_TMP102
>  	tristate "Texas Instruments TMP102"
>  	depends on I2C
> +	depends on THERMAL || !THERMAL_OF
>  	help
>  	  If you say yes here you get support for Texas Instruments TMP102
>  	  sensor chips.
> 
> 


-- 
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] hwmon: Fix SENSORS_TMP102 dependencies to eliminate build errors
  2014-01-08  7:05 [PATCH] hwmon: Fix SENSORS_TMP102 dependencies to eliminate build errors Jean Delvare
  2014-01-08 12:20 ` Eduardo Valentin
@ 2014-01-08 13:49 ` Guenter Roeck
  1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2014-01-08 13:49 UTC (permalink / raw)
  To: Jean Delvare, Eduardo Valentin, Zhang Rui
  Cc: LM Sensors, linux-pm, Randy Dunlap

On 01/07/2014 11:05 PM, Jean Delvare wrote:
> Similar to what was done for the lm75 driver.
>
> Add depends on THERMAL since that is what provides the
> register/unregister functions above, but only if THERMAL_OF was
> selected as this is an optional feature of the driver.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: Eduardo Valentin <eduardo.valentin@ti.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/hwmon/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
>
> --- linux-3.13-rc7.orig/drivers/hwmon/Kconfig	2014-01-08 08:00:58.583072658 +0100
> +++ linux-3.13-rc7/drivers/hwmon/Kconfig	2014-01-08 08:01:36.928977997 +0100
> @@ -1285,6 +1285,7 @@ config SENSORS_THMC50
>   config SENSORS_TMP102
>   	tristate "Texas Instruments TMP102"
>   	depends on I2C
> +	depends on THERMAL || !THERMAL_OF
>   	help
>   	  If you say yes here you get support for Texas Instruments TMP102
>   	  sensor chips.
>
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-01-08 13:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-08  7:05 [PATCH] hwmon: Fix SENSORS_TMP102 dependencies to eliminate build errors Jean Delvare
2014-01-08 12:20 ` Eduardo Valentin
2014-01-08 13:49 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).