From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Kevin Hilman <khilman@deeprootsystems.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] drivers/cpufreq: delete non-required instances of include <linux/init.h>
Date: Thu, 9 Jan 2014 10:42:31 -0500 [thread overview]
Message-ID: <52CEC367.3030609@windriver.com> (raw)
In-Reply-To: <CAOh2x=mfQ1qoWBW3=kwML0aLYu60v107svb4knYwTwsSXTzEaQ@mail.gmail.com>
On 14-01-09 10:17 AM, Viresh Kumar wrote:
> On Thu, Jan 9, 2014 at 8:40 PM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
>> None of these files are actually using any __init type directives
>> and hence don't need to include <linux/init.h>. Most are just a
>> left over from __devinit and __cpuinit removal, or simply due to
>> code getting copied from one driver to the next.
>
> Are you sure? Its not only about devinit or cpuinit but module_init()
> and others as well. And they are pretty much used by most of them.
Actually, module_init is an interesting point; we are implicitly getting
init.h in module.h -- but (1) that should be explicit, and (2) module_init
should/could really be in module.h and not stuck in init.h
I'll add that to my queue and do some testing.
Thanks for the comments,
Paul.
prev parent reply other threads:[~2014-01-09 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 15:10 [PATCH] drivers/cpufreq: delete non-required instances of include <linux/init.h> Paul Gortmaker
2014-01-09 15:17 ` Viresh Kumar
2014-01-09 15:26 ` Paul Gortmaker
2014-01-09 15:39 ` Viresh Kumar
2014-01-09 15:42 ` Paul Gortmaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CEC367.3030609@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=cpufreq@vger.kernel.org \
--cc=khilman@deeprootsystems.com \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).