* [PATCH v3 1/2] thermal: add available policies attribute
@ 2014-01-16 9:31 Wei Ni
2014-01-16 13:47 ` Eduardo Valentin
0 siblings, 1 reply; 2+ messages in thread
From: Wei Ni @ 2014-01-16 9:31 UTC (permalink / raw)
To: eduardo.valentin, rui.zhang
Cc: mark.rutland, durgadoss.r, MLongnecker, swarren, linux-pm, Wei Ni
The Linux thermal framework support to change thermal governor
policy in userspace, but it can't show what available policies
supported.
This patch adds available_policies attribute to the thermal
framework, it can list the thermal governors which can be
used for a particular zone. This attribute is read only.
Change-Id: I63c25d0dba38ad8357265afceea59bbf336cde13
Signed-off-by: Wei Ni <wni@nvidia.com>
---
Documentation/thermal/sysfs-api.txt | 6 ++++++
drivers/thermal/thermal_core.c | 28 ++++++++++++++++++++++++++++
2 files changed, 34 insertions(+)
diff --git a/Documentation/thermal/sysfs-api.txt b/Documentation/thermal/sysfs-api.txt
index 87519cb..fe69bce 100644
--- a/Documentation/thermal/sysfs-api.txt
+++ b/Documentation/thermal/sysfs-api.txt
@@ -172,6 +172,7 @@ Thermal zone device sys I/F, created once it's registered:
|---temp: Current temperature
|---mode: Working mode of the thermal zone
|---policy: Thermal governor used for this zone
+ |---available_policies Available thermal governors for this zone
|---trip_point_[0-*]_temp: Trip point temperature
|---trip_point_[0-*]_type: Trip point type
|---trip_point_[0-*]_hyst: Hysteresis value for this trip point
@@ -238,6 +239,10 @@ policy
One of the various thermal governors used for a particular zone.
RW, Required
+available_policies
+ Availabe thermal governors which can be used for a particular zone.
+ RO, Required
+
trip_point_[0-*]_temp
The temperature above which trip point will be fired.
Unit: millidegree Celsius
@@ -330,6 +335,7 @@ method, the sys I/F structure will be built like this:
|---temp: 37000
|---mode: enabled
|---policy: step_wise
+ |---available_policies: step_wise fair_share
|---trip_point_0_temp: 100000
|---trip_point_0_type: critical
|---trip_point_1_temp: 80000
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 338a88b..fc9b2ae 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -761,6 +761,27 @@ policy_show(struct device *dev, struct device_attribute *devattr, char *buf)
return sprintf(buf, "%s\n", tz->governor->name);
}
+static ssize_t
+available_policies_show(struct device *dev, struct device_attribute *devattr,
+ char *buf)
+{
+ struct thermal_governor *pos;
+ ssize_t count = 0;
+ ssize_t size;
+
+ mutex_lock(&thermal_governor_lock);
+
+ list_for_each_entry(pos, &thermal_governor_list, governor_list) {
+ size = PAGE_SIZE - count;
+ count += scnprintf(buf + count, size, "%s ", pos->name);
+ }
+ count += scnprintf(buf + count, size, "\n");
+
+ mutex_unlock(&thermal_governor_lock);
+
+ return count;
+}
+
#ifdef CONFIG_THERMAL_EMULATION
static ssize_t
emul_temp_store(struct device *dev, struct device_attribute *attr,
@@ -794,6 +815,7 @@ static DEVICE_ATTR(temp, 0444, temp_show, NULL);
static DEVICE_ATTR(mode, 0644, mode_show, mode_store);
static DEVICE_ATTR(passive, S_IRUGO | S_IWUSR, passive_show, passive_store);
static DEVICE_ATTR(policy, S_IRUGO | S_IWUSR, policy_show, policy_store);
+static DEVICE_ATTR(available_policies, S_IRUGO, available_policies_show, NULL);
/* sys I/F for cooling device */
#define to_cooling_device(_dev) \
@@ -1527,6 +1549,11 @@ struct thermal_zone_device *thermal_zone_device_register(const char *type,
if (result)
goto unregister;
+ /* Create available_policies attribute */
+ result = device_create_file(&tz->device, &dev_attr_available_policies);
+ if (result)
+ goto unregister;
+
/* Update 'this' zone's governor information */
mutex_lock(&thermal_governor_lock);
@@ -1622,6 +1649,7 @@ void thermal_zone_device_unregister(struct thermal_zone_device *tz)
if (tz->ops->get_mode)
device_remove_file(&tz->device, &dev_attr_mode);
device_remove_file(&tz->device, &dev_attr_policy);
+ device_remove_file(&tz->device, &dev_attr_available_policies);
remove_trip_attrs(tz);
tz->governor = NULL;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 1/2] thermal: add available policies attribute
2014-01-16 9:31 [PATCH v3 1/2] thermal: add available policies attribute Wei Ni
@ 2014-01-16 13:47 ` Eduardo Valentin
0 siblings, 0 replies; 2+ messages in thread
From: Eduardo Valentin @ 2014-01-16 13:47 UTC (permalink / raw)
To: Wei Ni
Cc: eduardo.valentin, rui.zhang, mark.rutland, durgadoss.r,
MLongnecker, swarren, linux-pm
[-- Attachment #1: Type: text/plain, Size: 4468 bytes --]
On 16-01-2014 05:31, Wei Ni wrote:
> The Linux thermal framework support to change thermal governor
> policy in userspace, but it can't show what available policies
> supported.
>
> This patch adds available_policies attribute to the thermal
> framework, it can list the thermal governors which can be
> used for a particular zone. This attribute is read only.
>
> Change-Id: I63c25d0dba38ad8357265afceea59bbf336cde13
Remove gerrit IDs.
> Signed-off-by: Wei Ni <wni@nvidia.com>
> ---
> Documentation/thermal/sysfs-api.txt | 6 ++++++
> drivers/thermal/thermal_core.c | 28 ++++++++++++++++++++++++++++
> 2 files changed, 34 insertions(+)
>
> diff --git a/Documentation/thermal/sysfs-api.txt b/Documentation/thermal/sysfs-api.txt
> index 87519cb..fe69bce 100644
> --- a/Documentation/thermal/sysfs-api.txt
> +++ b/Documentation/thermal/sysfs-api.txt
> @@ -172,6 +172,7 @@ Thermal zone device sys I/F, created once it's registered:
> |---temp: Current temperature
> |---mode: Working mode of the thermal zone
> |---policy: Thermal governor used for this zone
> + |---available_policies Available thermal governors for this zone
> |---trip_point_[0-*]_temp: Trip point temperature
> |---trip_point_[0-*]_type: Trip point type
> |---trip_point_[0-*]_hyst: Hysteresis value for this trip point
> @@ -238,6 +239,10 @@ policy
> One of the various thermal governors used for a particular zone.
> RW, Required
>
> +available_policies
> + Availabe thermal governors which can be used for a particular zone.
s/Availabe/Available/g
> + RO, Required
> +
> trip_point_[0-*]_temp
> The temperature above which trip point will be fired.
> Unit: millidegree Celsius
> @@ -330,6 +335,7 @@ method, the sys I/F structure will be built like this:
> |---temp: 37000
> |---mode: enabled
> |---policy: step_wise
> + |---available_policies: step_wise fair_share
> |---trip_point_0_temp: 100000
> |---trip_point_0_type: critical
> |---trip_point_1_temp: 80000
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 338a88b..fc9b2ae 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -761,6 +761,27 @@ policy_show(struct device *dev, struct device_attribute *devattr, char *buf)
> return sprintf(buf, "%s\n", tz->governor->name);
> }
>
> +static ssize_t
> +available_policies_show(struct device *dev, struct device_attribute *devattr,
> + char *buf)
> +{
> + struct thermal_governor *pos;
> + ssize_t count = 0;
> + ssize_t size;
> +
> + mutex_lock(&thermal_governor_lock);
> +
> + list_for_each_entry(pos, &thermal_governor_list, governor_list) {
> + size = PAGE_SIZE - count;
> + count += scnprintf(buf + count, size, "%s ", pos->name);
> + }
> + count += scnprintf(buf + count, size, "\n");
> +
> + mutex_unlock(&thermal_governor_lock);
> +
> + return count;
> +}
> +
> #ifdef CONFIG_THERMAL_EMULATION
> static ssize_t
> emul_temp_store(struct device *dev, struct device_attribute *attr,
> @@ -794,6 +815,7 @@ static DEVICE_ATTR(temp, 0444, temp_show, NULL);
> static DEVICE_ATTR(mode, 0644, mode_show, mode_store);
> static DEVICE_ATTR(passive, S_IRUGO | S_IWUSR, passive_show, passive_store);
> static DEVICE_ATTR(policy, S_IRUGO | S_IWUSR, policy_show, policy_store);
> +static DEVICE_ATTR(available_policies, S_IRUGO, available_policies_show, NULL);
>
> /* sys I/F for cooling device */
> #define to_cooling_device(_dev) \
> @@ -1527,6 +1549,11 @@ struct thermal_zone_device *thermal_zone_device_register(const char *type,
> if (result)
> goto unregister;
>
> + /* Create available_policies attribute */
> + result = device_create_file(&tz->device, &dev_attr_available_policies);
> + if (result)
> + goto unregister;
> +
> /* Update 'this' zone's governor information */
> mutex_lock(&thermal_governor_lock);
>
> @@ -1622,6 +1649,7 @@ void thermal_zone_device_unregister(struct thermal_zone_device *tz)
> if (tz->ops->get_mode)
> device_remove_file(&tz->device, &dev_attr_mode);
> device_remove_file(&tz->device, &dev_attr_policy);
> + device_remove_file(&tz->device, &dev_attr_available_policies);
> remove_trip_attrs(tz);
> tz->governor = NULL;
>
>
--
You have got to be excited about what you are doing. (L. Lamport)
Eduardo Valentin
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-16 13:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-16 9:31 [PATCH v3 1/2] thermal: add available policies attribute Wei Ni
2014-01-16 13:47 ` Eduardo Valentin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).