From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Gortmaker Subject: Re: [PATCH RESEND] cpufreq: exynos: Fix build error of no type of module_init Date: Wed, 22 Jan 2014 10:46:33 -0500 Message-ID: <52DFE7D9.5050001@windriver.com> References: <1390400476-22951-1-git-send-email-k.kozlowski@samsung.com> <1390402760.18340.6.camel@AMDC1943> <1390405030.18340.11.camel@AMDC1943> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1390405030.18340.11.camel@AMDC1943> Sender: cpufreq-owner@vger.kernel.org To: Krzysztof Kozlowski , Viresh Kumar Cc: "Rafael J. Wysocki" , Kukjin Kim , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc , Linux Kernel Mailing List , Lukasz Majewski , Tomasz Figa , Kyungmin Park List-Id: linux-pm@vger.kernel.org On 14-01-22 10:37 AM, Krzysztof Kozlowski wrote: >=20 >> >> On Wed, 2014-01-22 at 20:12 +0530, Viresh Kumar wrote: >>> On 22 January 2014 19:51, Krzysztof Kozlowski wrote: >>>> Add missing include to fix build error: >>>> drivers/cpufreq/exynos-cpufreq.c:292:1: warning: data definition h= as no type or storage class [enabled by default] >>>> drivers/cpufreq/exynos-cpufreq.c:292:1: error: type defaults to =E2= =80=98int=E2=80=99 in declaration of =E2=80=98module_init=E2=80=99 [-We= rror=3Dimplicit-int] >>>> drivers/cpufreq/exynos-cpufreq.c:292:1: warning: parameter names (= without types) in function declaration [enabled by default] >>>> drivers/cpufreq/exynos-cpufreq.c:292:1: warning: data definition h= as no type or storage class [enabled by default] >>>> drivers/cpufreq/exynos-cpufreq.c:292:1: error: type defaults to =E2= =80=98int=E2=80=99 in declaration of =E2=80=98module_exit=E2=80=99 [-We= rror=3Dimplicit-int] >>>> drivers/cpufreq/exynos-cpufreq.c:292:1: warning: parameter names (= without types) in function declaration [enabled by default] >>>> drivers/cpufreq/exynos-cpufreq.c:292:1: warning: =E2=80=98exynos_c= pufreq_platdrv_init=E2=80=99 defined but not used [-Wunused-function] >>>> cc1: some warnings being treated as errors >>>> make[2]: *** [drivers/cpufreq/exynos-cpufreq.o] Error 1 >>>> make[1]: *** [drivers/cpufreq] Error 2 >>>> >>>> Build error happens on gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubu= ntu5) >>>> and was introduced by commit d568b6f71df1 (cpufreq: exynos: Conver= t >>>> exynos-cpufreq to platform driver). >>>> >>>> Signed-off-by: Krzysztof Kozlowski >>>> Cc: Lukasz Majewski >>>> Cc: Tomasz Figa >>>> Cc: Kyungmin Park >>>> --- >>>> drivers/cpufreq/exynos-cpufreq.c | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/ex= ynos-cpufreq.c >>>> index fcd2914d081a..fa54c2b88dd7 100644 >>>> --- a/drivers/cpufreq/exynos-cpufreq.c >>>> +++ b/drivers/cpufreq/exynos-cpufreq.c >>>> @@ -17,6 +17,7 @@ >>>> #include >>>> #include >>>> #include >>>> +#include >>>> #include >>> >>> I am surprised how that patch went through then? And nothing was >>> reported by kbuild for it.. >> >> Hi, >> >> A little more explanation from my side: the build error actually hap= pens >> only on next/master, not Linus' tree. >> >> Mentioned commit which changes the driver to platform driver is in >> mainline since 3.12-rc2 so it seems this is not the cause of the bui= ld >> error. I think I need to find first the real cause of this build err= or. >> >> Best regards, >> Krzysztof >=20 > After bisecting, the real commit for build error is: > caa7dcde7c424cdc81698a6e4e48072eb67ec67e > module: relocate module_init from init.h to module.h Yep, even though I fixed a crap-tonne of implicit includes, and built all the arm configs, some were bound to sneak through. I'll push a fix shortly to the init cleanup queue: http://git.kernel.org/cgit/linux/kernel/git/paulg/init.git/ so it will be fine for the next linux-next tree. Thanks, Paul. -- >=20 > My patch seems valid although the reason in commit msg should be upda= ted: > ################ > Add missing include to fix build error: > drivers/cpufreq/exynos-cpufreq.c:292:1: warning: data definition has = no type or storage class [enabled by default] > drivers/cpufreq/exynos-cpufreq.c:292:1: error: type defaults to =E2=80= =98int=E2=80=99 in declaration of =E2=80=98module_init=E2=80=99 [-Werro= r=3Dimplicit-int] > drivers/cpufreq/exynos-cpufreq.c:292:1: warning: parameter names (wit= hout types) in function declaration [enabled by default] > drivers/cpufreq/exynos-cpufreq.c:292:1: warning: data definition has = no type or storage class [enabled by default] > drivers/cpufreq/exynos-cpufreq.c:292:1: error: type defaults to =E2=80= =98int=E2=80=99 in declaration of =E2=80=98module_exit=E2=80=99 [-Werro= r=3Dimplicit-int] > drivers/cpufreq/exynos-cpufreq.c:292:1: warning: parameter names (wit= hout types) in function declaration [enabled by default] > drivers/cpufreq/exynos-cpufreq.c:292:1: warning: =E2=80=98exynos_cpuf= req_platdrv_init=E2=80=99 defined but not used [-Wunused-function] > cc1: some warnings being treated as errors > make[2]: *** [drivers/cpufreq/exynos-cpufreq.o] Error 1 > make[1]: *** [drivers/cpufreq] Error 2 >=20 > Build error happens on gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu= 5) > and was introduced in next tree by commit caa7dcde7c42 (module: reloc= ate > module_init from init.h to module.h). > ################ >=20 >=20 >=20