linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dirk Brandewie <dirk.brandewie@gmail.com>
To: dirk.brandewie@gmail.com, rjw@rjwysocki.net, linux-pm@vger.kernel.org
Subject: Re: [PATCH] intel_pstate: Remove periodic P state boost
Date: Thu, 23 Jan 2014 08:51:54 -0800	[thread overview]
Message-ID: <52E148AA.7030406@intel.com> (raw)
In-Reply-To: <1390495707-6297-1-git-send-email-dirk.j.brandewie@intel.com>

Please ignore. Sorry for the noise I found this in the 3.14 material.

--Dirk
On 01/23/2014 08:48 AM, dirk.brandewie@gmail.com wrote:
> From: Dirk Brandewie <dirk.j.brandewie@intel.com>
>
> Remove the periodic P state boost.  This code required for some corner
> case benchmark tests.  The calculation of the required P state was
> incorrect/inaccurate and would not allow P state increase.
>
> This was resolved by a combination of commits:
>    2134ed4 cpufreq / intel_pstate: Change to scale off of max P-state
>    d253d2a intel_pstate: Improve accuracy by not truncating until final result
>
> reference:
>    https://bugzilla.kernel.org/show_bug.cgi?id=64271
>
> Reported-by: Doug Smythies <dsmythies@telus.net>
> Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
> ---
>   drivers/cpufreq/intel_pstate.c | 11 -----------
>   1 file changed, 11 deletions(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index d51f17ed..5a060eb 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -84,8 +84,6 @@ struct cpudata {
>   	struct pstate_data pstate;
>   	struct _pid pid;
>
> -	int min_pstate_count;
> -
>   	u64	prev_aperf;
>   	u64	prev_mperf;
>   	int	sample_ptr;
> @@ -568,15 +566,6 @@ static void intel_pstate_timer_func(unsigned long __data)
>
>   	intel_pstate_sample(cpu);
>   	intel_pstate_adjust_busy_pstate(cpu);
> -
> -	if (cpu->pstate.current_pstate == cpu->pstate.min_pstate) {
> -		cpu->min_pstate_count++;
> -		if (!(cpu->min_pstate_count % 5)) {
> -			intel_pstate_set_pstate(cpu, cpu->pstate.max_pstate);
> -		}
> -	} else
> -		cpu->min_pstate_count = 0;
> -
>   	intel_pstate_set_sample_time(cpu);
>   }
>
>


      reply	other threads:[~2014-01-23 16:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 16:48 [PATCH] intel_pstate: Remove periodic P state boost dirk.brandewie
2014-01-23 16:51 ` Dirk Brandewie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E148AA.7030406@intel.com \
    --to=dirk.brandewie@gmail.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).