[PATCH] intel_pstate: Remove periodic P state boost

[PATCH] intel_pstate: Remove periodic P state boost

[dirk.brandewie]

From: Dirk Brandewie <dirk.j.brandewie@intel.com>

Remove the periodic P state boost.  This code required for some corner
case benchmark tests.  The calculation of the required P state was
incorrect/inaccurate and would not allow P state increase.

This was resolved by a combination of commits:
  2134ed4 cpufreq / intel_pstate: Change to scale off of max P-state
  d253d2a intel_pstate: Improve accuracy by not truncating until final result

reference:
  https://bugzilla.kernel.org/show_bug.cgi?id=64271

Reported-by: Doug Smythies <dsmythies@telus.net>
Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
---
 drivers/cpufreq/intel_pstate.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index d51f17ed..5a060eb 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -84,8 +84,6 @@ struct cpudata {
 	struct pstate_data pstate;
 	struct _pid pid;
 
-	int min_pstate_count;
-
 	u64	prev_aperf;
 	u64	prev_mperf;
 	int	sample_ptr;
@@ -568,15 +566,6 @@ static void intel_pstate_timer_func(unsigned long __data)
 
 	intel_pstate_sample(cpu);
 	intel_pstate_adjust_busy_pstate(cpu);
-
-	if (cpu->pstate.current_pstate == cpu->pstate.min_pstate) {
-		cpu->min_pstate_count++;
-		if (!(cpu->min_pstate_count % 5)) {
-			intel_pstate_set_pstate(cpu, cpu->pstate.max_pstate);
-		}
-	} else
-		cpu->min_pstate_count = 0;
-
 	intel_pstate_set_sample_time(cpu);
 }
 
-- 
1.8.3.1

Re: [PATCH] intel_pstate: Remove periodic P state boost

[Dirk Brandewie]

Please ignore. Sorry for the noise I found this in the 3.14 material.

--Dirk
On 01/23/2014 08:48 AM, dirk.brandewie@gmail.com wrote:
> From: Dirk Brandewie <dirk.j.brandewie@intel.com>
>
> Remove the periodic P state boost.  This code required for some corner
> case benchmark tests.  The calculation of the required P state was
> incorrect/inaccurate and would not allow P state increase.
>
> This was resolved by a combination of commits:
>    2134ed4 cpufreq / intel_pstate: Change to scale off of max P-state
>    d253d2a intel_pstate: Improve accuracy by not truncating until final result
>
> reference:
>    https://bugzilla.kernel.org/show_bug.cgi?id=64271
>
> Reported-by: Doug Smythies <dsmythies@telus.net>
> Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
> ---
>   drivers/cpufreq/intel_pstate.c | 11 -----------
>   1 file changed, 11 deletions(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index d51f17ed..5a060eb 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -84,8 +84,6 @@ struct cpudata {
>   	struct pstate_data pstate;
>   	struct _pid pid;
>
> -	int min_pstate_count;
> -
>   	u64	prev_aperf;
>   	u64	prev_mperf;
>   	int	sample_ptr;
> @@ -568,15 +566,6 @@ static void intel_pstate_timer_func(unsigned long __data)
>
>   	intel_pstate_sample(cpu);
>   	intel_pstate_adjust_busy_pstate(cpu);
> -
> -	if (cpu->pstate.current_pstate == cpu->pstate.min_pstate) {
> -		cpu->min_pstate_count++;
> -		if (!(cpu->min_pstate_count % 5)) {
> -			intel_pstate_set_pstate(cpu, cpu->pstate.max_pstate);
> -		}
> -	} else
> -		cpu->min_pstate_count = 0;
> -
>   	intel_pstate_set_sample_time(cpu);
>   }
>
>