From mboxrd@z Thu Jan 1 00:00:00 1970 From: Preeti U Murthy Subject: Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call() Date: Thu, 06 Feb 2014 22:19:02 +0530 Message-ID: <52F3BCFE.3010703@linux.vnet.ibm.com> References: <1391696188-14540-1-git-send-email-nicolas.pitre@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from e23smtp09.au.ibm.com ([202.81.31.142]:33948 "EHLO e23smtp09.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755577AbaBFQwn (ORCPT ); Thu, 6 Feb 2014 11:52:43 -0500 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 7 Feb 2014 02:52:41 +1000 In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Daniel Lezcano Cc: Nicolas Pitre , Benjamin Herrenschmidt , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , "Rafael J. Wysocki" , LKML , Linux ARM Kernel ML , linuxppc-dev@lists.ozlabs.org, "linux-pm@vger.kernel.org" , Lists linaro-kernel Hi Daniel, On 02/06/2014 09:55 PM, Daniel Lezcano wrote: > Hi Nico, > > > On 6 February 2014 14:16, Nicolas Pitre wrote: > >> The core idle loop now takes care of it. >> >> Signed-off-by: Nicolas Pitre >> --- >> arch/powerpc/platforms/powernv/setup.c | 13 +------------ >> 1 file changed, 1 insertion(+), 12 deletions(-) >> >> diff --git a/arch/powerpc/platforms/powernv/setup.c >> b/arch/powerpc/platforms/powernv/setup.c >> index 21166f65c9..a932feb290 100644 >> --- a/arch/powerpc/platforms/powernv/setup.c >> +++ b/arch/powerpc/platforms/powernv/setup.c >> @@ -26,7 +26,6 @@ >> #include >> #include >> #include >> -#include >> >> #include >> #include >> @@ -217,16 +216,6 @@ static int __init pnv_probe(void) >> return 1; >> } >> >> -void powernv_idle(void) >> -{ >> - /* Hook to cpuidle framework if available, else >> - * call on default platform idle code >> - */ >> - if (cpuidle_idle_call()) { >> - power7_idle(); >> - } >> > > The cpuidle_idle_call is called from arch_cpu_idle in > arch/powerpc/kernel/idle.c between a ppc64_runlatch_off|on section. > Shouldn't the cpuidle-powernv driver call these functions when entering > idle ? Yes they should, I will send out a patch that does that ontop of this. There have been cpuidle driver cleanups for powernv and pseries in this merge window. While no change would be required in the pseries cpuidle driver as a result of Nicolas's cleanup, we would need to add the ppc64_runlatch_on and off functions before and after the entry into the powernv idle states. Thanks Regards Preeti U Murthy > > -- Daniel > > >> -} >> - >> define_machine(powernv) { >> .name = "PowerNV", >> .probe = pnv_probe, >> @@ -236,7 +225,7 @@ define_machine(powernv) { >> .show_cpuinfo = pnv_show_cpuinfo, >> .progress = pnv_progress, >> .machine_shutdown = pnv_shutdown, >> - .power_save = powernv_idle, >> + .power_save = power7_idle, >> .calibrate_decr = generic_calibrate_decr, >> #ifdef CONFIG_KEXEC >> .kexec_cpu_down = pnv_kexec_cpu_down, >> -- >> 1.8.4.108.g55ea5f6 >> >> >