From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Paul Burton <paul.burton@imgtec.com>, linux-mips@linux-mips.org
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, linux-pm@vger.kernel.org
Subject: Re: [PATCH 09/10] cpuidle: declare cpuidle_dev in cpuidle.h
Date: Thu, 20 Feb 2014 14:35:18 +0100 [thread overview]
Message-ID: <53060496.6000303@linaro.org> (raw)
In-Reply-To: <1389794137-11361-10-git-send-email-paul.burton@imgtec.com>
On 01/15/2014 02:55 PM, Paul Burton wrote:
> Declaring this allows drivers which need to initialise each struct
> cpuidle_device at initialisation time to make use of the structures
> already defined in cpuidle.c, rather than having to wastefully define
> their own.
>
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: linux-pm@vger.kernel.org
> ---
> include/linux/cpuidle.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/cpuidle.h b/include/linux/cpuidle.h
> index 50fcbb0..bab4f33 100644
> --- a/include/linux/cpuidle.h
> +++ b/include/linux/cpuidle.h
> @@ -84,6 +84,7 @@ struct cpuidle_device {
> };
>
> DECLARE_PER_CPU(struct cpuidle_device *, cpuidle_devices);
> +DECLARE_PER_CPU(struct cpuidle_device, cpuidle_dev);
Nak. When a device is registered, it is assigned to the cpuidle_devices
pointer and the backend driver should use it.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2014-02-20 13:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1389794137-11361-1-git-send-email-paul.burton@imgtec.com>
2014-01-15 13:55 ` [PATCH 08/10] MIPS: support use of cpuidle Paul Burton
2014-02-20 8:52 ` Daniel Lezcano
2014-02-20 9:57 ` Paul Burton
2014-01-15 13:55 ` [PATCH 09/10] cpuidle: declare cpuidle_dev in cpuidle.h Paul Burton
2014-02-20 13:35 ` Daniel Lezcano [this message]
2014-02-20 13:41 ` Paul Burton
2014-02-20 13:53 ` Daniel Lezcano
2014-02-20 14:00 ` Paul Burton
2014-02-25 14:39 ` Daniel Lezcano
2014-01-15 13:55 ` [PATCH 10/10] cpuidle: cpuidle driver for MIPS CPS Paul Burton
2014-02-25 15:33 ` Daniel Lezcano
2014-02-25 22:12 ` Paul Burton
2014-02-26 14:37 ` Daniel Lezcano
2014-02-27 9:50 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53060496.6000303@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-pm@vger.kernel.org \
--cc=paul.burton@imgtec.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).