From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Ni Subject: Re: [PATCH] Thermal: Allow first update of cooling device state Date: Mon, 24 Feb 2014 15:13:56 +0800 Message-ID: <530AF134.4000505@nvidia.com> References: <1392606175-19635-1-git-send-email-wni@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from hqemgate14.nvidia.com ([216.228.121.143]:17169 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751326AbaBXHOU (ORCPT ); Mon, 24 Feb 2014 02:14:20 -0500 In-Reply-To: <1392606175-19635-1-git-send-email-wni@nvidia.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "rui.zhang@intel.com" Cc: "durgadoss.r@intel.com" , "eduardo.valentin@ti.com" , "linux-pm@vger.kernel.org" , Wei Ni , "linux-kernel@vger.kernel.org" Hi, Rui Do you have any comment for it ? Thanks. Wei. On 02/17/2014 11:02 AM, Wei Ni wrote: > In initialization, if the cooling device is initialized at > max cooling state, and the thermal zone temperature is below > the first trip point, then the cooling state can't be updated > to the right state, untill the first trip point be triggered. > > To fix this issue, allow first update of cooling device state > during registration, initialized "updated" device field as > "false" (instead of "true"). > > Signed-off-by: Wei Ni > --- > drivers/thermal/thermal_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c > index 338a88b..02f57af 100644 > --- a/drivers/thermal/thermal_core.c > +++ b/drivers/thermal/thermal_core.c > @@ -1107,7 +1107,7 @@ __thermal_cooling_device_register(struct device_node *np, > INIT_LIST_HEAD(&cdev->thermal_instances); > cdev->np = np; > cdev->ops = ops; > - cdev->updated = true; > + cdev->updated = false; > cdev->device.class = &thermal_class; > cdev->devdata = devdata; > dev_set_name(&cdev->device, "cooling_device%d", cdev->id); >