* [PATCH v2] thermal,rcar_thermal: Add dependency on HAS_IOMEM
@ 2014-01-27 8:40 Richard Weinberger
2014-01-27 11:32 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Richard Weinberger @ 2014-01-27 8:40 UTC (permalink / raw)
To: rui.zhang
Cc: eduardo.valentin, linux-pm, linux-kernel, horms,
laurent.pinchart+renesas, Richard Weinberger
Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with COMPILE_TEST)
broke build on archs wihout io memory.
On archs like S390 or um this driver cannot build nor work.
Make it depend on HAS_IOMEM to bypass build failures.
drivers/thermal/rcar_thermal.c:404: undefined reference to `devm_ioremap_resource'
drivers/thermal/rcar_thermal.c:426: undefined reference to `devm_ioremap_resource'
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/thermal/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 35c0664..88efa8f 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -136,6 +136,7 @@ config SPEAR_THERMAL
config RCAR_THERMAL
tristate "Renesas R-Car thermal driver"
depends on ARCH_SHMOBILE || COMPILE_TEST
+ depends on HAS_IOMEM
help
Enable this to plug the R-Car thermal sensor driver into the Linux
thermal framework.
--
1.8.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] thermal,rcar_thermal: Add dependency on HAS_IOMEM
2014-01-27 8:40 [PATCH v2] thermal,rcar_thermal: Add dependency on HAS_IOMEM Richard Weinberger
@ 2014-01-27 11:32 ` Laurent Pinchart
2014-02-26 11:59 ` Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2014-01-27 11:32 UTC (permalink / raw)
To: Richard Weinberger
Cc: rui.zhang, eduardo.valentin, linux-pm, linux-kernel, horms
Hi Richard,
Thank you for the patch.
On Monday 27 January 2014 09:40:58 Richard Weinberger wrote:
> Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with
> COMPILE_TEST) broke build on archs wihout io memory.
>
> On archs like S390 or um this driver cannot build nor work.
> Make it depend on HAS_IOMEM to bypass build failures.
>
> drivers/thermal/rcar_thermal.c:404: undefined reference to
> `devm_ioremap_resource' drivers/thermal/rcar_thermal.c:426: undefined
> reference to `devm_ioremap_resource'
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I'm not the driver maintainer so I won't take this patch in my tree. Could you
please keep an eye on it to make sure it gets picked by the maintainers ?
> ---
> drivers/thermal/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 35c0664..88efa8f 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -136,6 +136,7 @@ config SPEAR_THERMAL
> config RCAR_THERMAL
> tristate "Renesas R-Car thermal driver"
> depends on ARCH_SHMOBILE || COMPILE_TEST
> + depends on HAS_IOMEM
> help
> Enable this to plug the R-Car thermal sensor driver into the Linux
> thermal framework.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] thermal,rcar_thermal: Add dependency on HAS_IOMEM
2014-01-27 11:32 ` Laurent Pinchart
@ 2014-02-26 11:59 ` Richard Weinberger
0 siblings, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2014-02-26 11:59 UTC (permalink / raw)
To: Laurent Pinchart
Cc: rui.zhang, eduardo.valentin, linux-pm, linux-kernel, horms
Am 27.01.2014 12:32, schrieb Laurent Pinchart:
> Hi Richard,
>
> Thank you for the patch.
>
> On Monday 27 January 2014 09:40:58 Richard Weinberger wrote:
>> Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with
>> COMPILE_TEST) broke build on archs wihout io memory.
>>
>> On archs like S390 or um this driver cannot build nor work.
>> Make it depend on HAS_IOMEM to bypass build failures.
>>
>> drivers/thermal/rcar_thermal.c:404: undefined reference to
>> `devm_ioremap_resource' drivers/thermal/rcar_thermal.c:426: undefined
>> reference to `devm_ioremap_resource'
>>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> I'm not the driver maintainer so I won't take this patch in my tree. Could you
> please keep an eye on it to make sure it gets picked by the maintainers ?
Ping?
Thanks,
//richard
>> ---
>> drivers/thermal/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
>> index 35c0664..88efa8f 100644
>> --- a/drivers/thermal/Kconfig
>> +++ b/drivers/thermal/Kconfig
>> @@ -136,6 +136,7 @@ config SPEAR_THERMAL
>> config RCAR_THERMAL
>> tristate "Renesas R-Car thermal driver"
>> depends on ARCH_SHMOBILE || COMPILE_TEST
>> + depends on HAS_IOMEM
>> help
>> Enable this to plug the R-Car thermal sensor driver into the Linux
>> thermal framework.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-26 11:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-27 8:40 [PATCH v2] thermal,rcar_thermal: Add dependency on HAS_IOMEM Richard Weinberger
2014-01-27 11:32 ` Laurent Pinchart
2014-02-26 11:59 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).