Re: [PATCH v2] power: add an API to log wakeup reasons

[John Stultz <john.stultz@linaro.org>]

On 03/11/2014 07:02 PM, Ruchi Kandoi wrote:
> Add API log_wakeup_reason() and expose it to userspace via sysfs path
> /sys/kernel/wakeup_reasons/last_resume_reason
> This is useful for power management diagnostic purposes.

Thanks for re-submitting!

This commit message is still really too brief, focusing only on what
you're doing and not *why*. You should include some of the rational you
provided in in your earlier reply.

The following template is usually good to follow:

1) The Why: Explanation of a problem (and how it came to be) or
problematic use case to be overcome.

2) The What: Your approach or design to solving the problem, with
details on any tradeoffs, or particular benefits of your solution that
should be noted.

I know it can seem terribly verbose for small patches, but it helps
maintainers and other reviewers get into the right context in order to
understand what your patch does before they look at the code.

thanks
-john