From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: [PATCH v2] kernel/power/hibernate.c: use 'u64' instead of 's64' to avoid warning Date: Tue, 22 Apr 2014 09:29:20 +0800 Message-ID: <5355C5F0.6020606@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-pb0-f41.google.com ([209.85.160.41]:45824 "EHLO mail-pb0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751138AbaDVB31 (ORCPT ); Mon, 21 Apr 2014 21:29:27 -0400 Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "Rafael J. Wysocki" , Pavel Machek , Guan Xuetao , len.brown@intel.com Cc: "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" =46or do_div(), it need 'u64' type, which means the outside must be sur= e of 'start' is not bigger than 'stop', or it will report warning. Even if 'start' was really bigger than 'stop', it would print incorrect information, but for kernel, it still can continue, so use WARN_ON() is enough. The related warning (with allmodconfig for unicore32): CC kernel/power/hibernate.o kernel/power/hibernate.c: In function =91swsusp_show_speed=92: kernel/power/hibernate.c:237: warning: comparison of distinct pointer= types lacks a cast Signed-off-by: Chen Gang --- kernel/power/hibernate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c index f4f2073..d5117d5 100644 --- a/kernel/power/hibernate.c +++ b/kernel/power/hibernate.c @@ -228,12 +228,13 @@ static void platform_recover(int platform_mode) void swsusp_show_speed(struct timeval *start, struct timeval *stop, unsigned nr_pages, char *msg) { - s64 elapsed_centisecs64; + u64 elapsed_centisecs64; int centisecs; int k; int kps; =20 elapsed_centisecs64 =3D timeval_to_ns(stop) - timeval_to_ns(start); + WARN_ON((s64)elapsed_centisecs64 < 0); do_div(elapsed_centisecs64, NSEC_PER_SEC / 100); centisecs =3D elapsed_centisecs64; if (centisecs =3D=3D 0) --=20 1.9.2.459.g68773ac