From: Stratos Karafotis <stratosk@semaphore.gr>
To: Yuyang Du <yuyang.du@intel.com>
Cc: Dirk Brandewie <dirk.brandewie@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Dirk Brandewie <dirk.j.brandewie@intel.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Doug Smythies <dsmythies@telus.net>
Subject: Re: [RFC PATCH] cpufreq: intel_pstate: Change the calculation of next pstate
Date: Tue, 13 May 2014 07:16:24 +0300 [thread overview]
Message-ID: <53719C98.1010103@semaphore.gr> (raw)
In-Reply-To: <20140512200140.GA10676@intel.com>
On 12/05/2014 11:01 μμ, Yuyang Du wrote:
> On Tue, May 13, 2014 at 06:59:42AM +0300, Stratos Karafotis wrote:
>> Hi,
>>
>> On 12/05/2014 10:34 μμ, Yuyang Du wrote:
>>> On Mon, May 12, 2014 at 11:30:03PM +0300, Stratos Karafotis wrote:
>>>> On 09/05/2014 05:56 μμ, Stratos Karafotis wrote:
>>>>
>>>> Next performance state = min_perf + (max_perf - min_perf) * load / 100
>>>>
>>> Hi,
>>>
>>> This formula is fundamentally broken. You need to associate the load with its
>>> frequency.
>>
>> Could you please explain why is it broken? I think the load should be
>> independent from the current frequency.
>
> Why independent? The load not (somewhat) determined by that?
>
>
Maybe, in some cases yes. But not always.
For example, please consider a CPU running a tight "for" loop in 100MHz
for a couple of seconds. This produces a load of 100%.
It will produce the same load (100%) in any other frequency.
Stratos
next prev parent reply other threads:[~2014-05-13 4:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 23:57 [RFC PATCH] cpufreq: intel_pstate: Change the calculation of next pstate Stratos Karafotis
2014-05-08 20:52 ` Dirk Brandewie
2014-05-09 14:56 ` Stratos Karafotis
2014-05-12 20:30 ` Stratos Karafotis
2014-05-12 19:34 ` Yuyang Du
2014-05-13 3:59 ` Stratos Karafotis
2014-05-12 20:01 ` Yuyang Du
2014-05-13 4:16 ` Stratos Karafotis [this message]
2014-05-12 20:34 ` Yuyang Du
2014-05-17 6:52 ` Stratos Karafotis
[not found] <bf3034d0-5c89-4ddb-921a-a92a4aed39f8@fmsmsx105.amr.corp.intel.com>
2014-05-12 21:59 ` Yuyang Du
2014-05-13 13:39 ` Stratos Karafotis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53719C98.1010103@semaphore.gr \
--to=stratosk@semaphore.gr \
--cc=dirk.brandewie@gmail.com \
--cc=dirk.j.brandewie@intel.com \
--cc=dsmythies@telus.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
--cc=yuyang.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).