* [PATCH] cpufreq: Tegra: drop wrapper around tegra_update_cpu_speed()
@ 2014-05-15 5:51 Viresh Kumar
2014-05-15 18:44 ` Stephen Warren
0 siblings, 1 reply; 4+ messages in thread
From: Viresh Kumar @ 2014-05-15 5:51 UTC (permalink / raw)
To: rjw, swarren
Cc: linaro-kernel, linux-pm, linux-kernel, arvind.chauhan,
Viresh Kumar
Tegra has implemented an unnecessary wrapper over tegra_update_cpu_speed(), i.e.
tegra_target(), which wasn't doing anything apart of calling
tegra_update_cpu_speed(). Get rid of that and use tegra_target() directly.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/tegra-cpufreq.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/cpufreq/tegra-cpufreq.c b/drivers/cpufreq/tegra-cpufreq.c
index 63f0059..6e774c6 100644
--- a/drivers/cpufreq/tegra-cpufreq.c
+++ b/drivers/cpufreq/tegra-cpufreq.c
@@ -82,9 +82,9 @@ out:
return ret;
}
-static int tegra_update_cpu_speed(struct cpufreq_policy *policy,
- unsigned long rate)
+static int tegra_target(struct cpufreq_policy *policy, unsigned int index)
{
+ unsigned long rate = freq_table[index].frequency;
int ret = 0;
/*
@@ -106,11 +106,6 @@ static int tegra_update_cpu_speed(struct cpufreq_policy *policy,
return ret;
}
-static int tegra_target(struct cpufreq_policy *policy, unsigned int index)
-{
- return tegra_update_cpu_speed(policy, freq_table[index].frequency);
-}
-
static int tegra_cpu_init(struct cpufreq_policy *policy)
{
int ret;
--
2.0.0.rc2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] cpufreq: Tegra: drop wrapper around tegra_update_cpu_speed()
2014-05-15 5:51 [PATCH] cpufreq: Tegra: drop wrapper around tegra_update_cpu_speed() Viresh Kumar
@ 2014-05-15 18:44 ` Stephen Warren
2014-05-16 6:06 ` Viresh Kumar
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Warren @ 2014-05-15 18:44 UTC (permalink / raw)
To: Viresh Kumar, rjw, swarren
Cc: linaro-kernel, linux-pm, linux-kernel, arvind.chauhan
On 05/14/2014 11:51 PM, Viresh Kumar wrote:
> Tegra has implemented an unnecessary wrapper over tegra_update_cpu_speed(), i.e.
> tegra_target(), which wasn't doing anything apart of calling
> tegra_update_cpu_speed(). Get rid of that and use tegra_target() directly.
I think it used to do something until some refactoring happened? Anyway,
Acked-by: Stephen Warren <swarren@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: Tegra: drop wrapper around tegra_update_cpu_speed()
2014-05-15 18:44 ` Stephen Warren
@ 2014-05-16 6:06 ` Viresh Kumar
2014-05-19 23:25 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Viresh Kumar @ 2014-05-16 6:06 UTC (permalink / raw)
To: Stephen Warren
Cc: Rafael J. Wysocki, Stephen Warren, Lists linaro-kernel,
linux-pm@vger.kernel.org, Linux Kernel Mailing List,
Arvind Chauhan
On 16 May 2014 00:14, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 05/14/2014 11:51 PM, Viresh Kumar wrote:
>> Tegra has implemented an unnecessary wrapper over tegra_update_cpu_speed(), i.e.
>> tegra_target(), which wasn't doing anything apart of calling
>> tegra_update_cpu_speed(). Get rid of that and use tegra_target() directly.
>
> I think it used to do something until some refactoring happened? Anyway,
Yep..
> Acked-by: Stephen Warren <swarren@nvidia.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: Tegra: drop wrapper around tegra_update_cpu_speed()
2014-05-16 6:06 ` Viresh Kumar
@ 2014-05-19 23:25 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2014-05-19 23:25 UTC (permalink / raw)
To: Viresh Kumar
Cc: Stephen Warren, Stephen Warren, Lists linaro-kernel,
linux-pm@vger.kernel.org, Linux Kernel Mailing List,
Arvind Chauhan
On Friday, May 16, 2014 11:36:48 AM Viresh Kumar wrote:
> On 16 May 2014 00:14, Stephen Warren <swarren@wwwdotorg.org> wrote:
> > On 05/14/2014 11:51 PM, Viresh Kumar wrote:
> >> Tegra has implemented an unnecessary wrapper over tegra_update_cpu_speed(), i.e.
> >> tegra_target(), which wasn't doing anything apart of calling
> >> tegra_update_cpu_speed(). Get rid of that and use tegra_target() directly.
> >
> > I think it used to do something until some refactoring happened? Anyway,
>
> Yep..
>
> > Acked-by: Stephen Warren <swarren@nvidia.com>
Patch queued up for 3.16, thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-19 23:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-15 5:51 [PATCH] cpufreq: Tegra: drop wrapper around tegra_update_cpu_speed() Viresh Kumar
2014-05-15 18:44 ` Stephen Warren
2014-05-16 6:06 ` Viresh Kumar
2014-05-19 23:25 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).