From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v5 5/6] exynos: cpuidle: do not allow cpuidle registration for Exynos5420 Date: Thu, 15 May 2014 23:26:51 +0200 Message-ID: <5375311B.2010202@gmail.com> References: <1400054637-21505-1-git-send-email-chander.kashyap@linaro.org> <1400054637-21505-6-git-send-email-chander.kashyap@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1400054637-21505-6-git-send-email-chander.kashyap@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Chander Kashyap , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: daniel.lezcano@linaro.org, lorenzo.pieralisi@arm.com, rjw@rjwysocki.net, kgene.kim@samsung.com, Chander Kashyap List-Id: linux-pm@vger.kernel.org Hi Chander, On 14.05.2014 10:03, Chander Kashyap wrote: > Exynos5420 is big.Little Soc. It uses cpuidle-big-litle generic cpuidle driver. > Hence do not allow exynos cpuidle driver registration for Exynos5420. > > Signed-off-by: Chander Kashyap > Signed-off-by: Chander Kashyap > Acked-by: Daniel Lezcano > --- > arch/arm/mach-exynos/cpuidle.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c > index 3dd385e..807a386 100644 > --- a/arch/arm/mach-exynos/cpuidle.c > +++ b/arch/arm/mach-exynos/cpuidle.c > @@ -218,6 +218,9 @@ static int exynos_cpuidle_probe(struct platform_device *pdev) > int cpu_id, ret; > struct cpuidle_device *device; > > + if (soc_is_exynos5420()) > + return -ENODEV; > + > if (soc_is_exynos5250()) > exynos5_core_down_clk(); > > Why not put this in exynos.c in exynos_dt_machine_init(), so exynos_cpuidle_init() is called only if not running on Exynos5420? Best regards, Tomasz