From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 6/7] ARM: EXYNOS: PM: fix register setup on EXYNOS4x12 for AFTR mode code Date: Fri, 16 May 2014 11:03:11 +0200 Message-ID: <5375D44F.7000505@linaro.org> References: <1399287439-31376-1-git-send-email-b.zolnierkie@samsung.com> <1399287439-31376-7-git-send-email-b.zolnierkie@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1399287439-31376-7-git-send-email-b.zolnierkie@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Bartlomiej Zolnierkiewicz , Kukjin Kim Cc: Tomasz Figa , Sachin Kamat , Viresh Kumar , "Rafael J. Wysocki" , Kyungmin Park , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org List-Id: linux-pm@vger.kernel.org On 05/05/2014 12:57 PM, Bartlomiej Zolnierkiewicz wrote: > Add S5P_CENTRAL_SEQ_OPTION register setup for EXYNOS4x12 to AFTR > mode code. Without this setup AFTR mode doesn't show any benefit > over WFI one. When this setup is applied AFTR mode reduces power > consumption by ~12% (as measured on Trats2 board). > > This change is a preparation for adding secure firmware support to > EXYNOS cpuidle driver. > > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > arch/arm/mach-exynos/pm.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c > index 18f6bf8..3922968 100644 > --- a/arch/arm/mach-exynos/pm.c > +++ b/arch/arm/mach-exynos/pm.c > @@ -391,6 +391,10 @@ static int exynos_cpu_pm_notifier(struct notifie= r_block *self, > case CPU_PM_ENTER: > if (cpu =3D=3D 0) { > exynos_pm_central_suspend(); > + if (soc_is_exynos4212() || soc_is_exynos4412()) > + __raw_writel(S5P_USE_STANDBY_WFI0 | > + S5P_USE_STANDBY_WFE0, > + S5P_CENTRAL_SEQ_OPTION); Why not put this code in the exynos_enter_aftr() ? > exynos_cpu_save_register(); > } > break; --=20 Linaro.org =E2=94=82 Open source software fo= r ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog