From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [PATCH Resend] driver/core: cpu: initialize opp table Date: Wed, 21 May 2014 10:35:04 +0100 Message-ID: <537C7348.7060202@arm.com> References: <60d825e8bfe01f8a5ff98fffaf51ffbf04c7d175.1400480033.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Return-path: Received: from service87.mimecast.com ([91.220.42.44]:59482 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbaEUJfE convert rfc822-to-8bit (ORCPT ); Wed, 21 May 2014 05:35:04 -0400 In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Viresh Kumar , "rjw@rjwysocki.net" Cc: Sudeep Holla , "linaro-kernel@lists.linaro.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Arvind Chauhan , "inderpal.s@samsung.com" , "pavel@ucw.cz" , "nm@ti.com" , "chander.kashyap@linaro.org" , Greg Kroah-Hartman , Amit Daniel Kachhap , Kukjin Kim , Shawn Guo On 19/05/14 07:29, Viresh Kumar wrote: > All drivers expecting CPU's OPPs from device tree initialize OPP table using > of_init_opp_table() and there is nothing driver specific in that. They all do it > in the same way adding to code redundancy. > > It would be better if we can get rid of code redundancy by initializing CPU OPPs > from core code for all CPUs that have a "operating-points" property defined in > their node. > > This patch initializes OPPs as soon as CPU device is registered in > register_cpu(). > This is really nice getting rid of all duplicate code. > Cc: Greg Kroah-Hartman > Cc: Amit Daniel Kachhap > Cc: Kukjin Kim > Cc: Shawn Guo > Cc: Sudeep Holla > Signed-off-by: Viresh Kumar > --- > V1-V2: > A colleague spotted some extra debug prints in my first mail :( > > Replace > + pr_err("****%s: failed to init OPP table for cpu%d, err: %d\n", > with > + pr_err("%s: failed to init OPP table for cpu%d, err: %d\n", > > drivers/base/cpu.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c > index 006b1bc..74ce944 100644 > --- a/drivers/base/cpu.c > +++ b/drivers/base/cpu.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > > #include "base.h" > > @@ -349,11 +350,20 @@ int register_cpu(struct cpu *cpu, int num) > if (cpu->hotpluggable) > cpu->dev.groups = hotplugable_cpu_attr_groups; > error = device_register(&cpu->dev); > - if (!error) > + if (!error) { > per_cpu(cpu_sys_devices, num) = &cpu->dev; > - if (!error) > register_cpu_under_node(num, cpu_to_node(num)); > > + /* Initialize CPUs OPP table */ > + if (of_node_get(cpu->dev.of_node)) { > + error = of_init_opp_table(&cpu->dev); > + if (error && error != -ENODEV) As Rafael mentioned it's better to have a wrapper function to hide these details. You should consider the fact that of_init_opp_table returns -EINVAL if CONFIG_PM_OPP not defined as well as when the list is invalid in the DT. IMO we can return -ENOSYS if not implemented(i.e. !CONFIG_PM_OPP) > + pr_err("%s: failed to init OPP table for cpu%d, err: %d\n", > + __func__, num, error); > + of_node_put(cpu->dev.of_node); > + } > + } > + > return error; > } > Regards, Sudeep