From: Dirk Brandewie <dirk.brandewie@gmail.com>
To: Stratos Karafotis <stratosk@semaphore.gr>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Dirk Brandewie <dirk.j.brandewie@intel.com>
Cc: dirk.brandewie@gmail.com,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org >> LKML"
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: intel_pstate: Remove unused member name of cpudata
Date: Wed, 21 May 2014 10:15:50 -0700 [thread overview]
Message-ID: <537CDF46.3000007@gmail.com> (raw)
In-Reply-To: <537B9B0B.1020404@semaphore.gr>
On 05/20/2014 11:12 AM, Stratos Karafotis wrote:
> Although, a value is assigned to member name of struct cpudata,
> it is never used.
>
> We can safely remove it.
>
> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
Acked-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
> ---
> drivers/cpufreq/intel_pstate.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 24a534a..a6d5afa 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -88,8 +88,6 @@ struct _pid {
> struct cpudata {
> int cpu;
>
> - char name[64];
> -
> struct timer_list timer;
>
> struct pstate_data pstate;
> @@ -544,8 +542,6 @@ static inline void intel_pstate_pstate_decrease(struct cpudata *cpu, int steps)
>
> static void intel_pstate_get_cpu_pstates(struct cpudata *cpu)
> {
> - sprintf(cpu->name, "Intel 2nd generation core");
> -
> cpu->pstate.min_pstate = pstate_funcs.get_min();
> cpu->pstate.max_pstate = pstate_funcs.get_max();
> cpu->pstate.turbo_pstate = pstate_funcs.get_turbo();
>
prev parent reply other threads:[~2014-05-21 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 18:12 [PATCH] cpufreq: intel_pstate: Remove unused member name of cpudata Stratos Karafotis
2014-05-21 4:35 ` Viresh Kumar
2014-05-21 17:15 ` Dirk Brandewie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537CDF46.3000007@gmail.com \
--to=dirk.brandewie@gmail.com \
--cc=dirk.j.brandewie@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=stratosk@semaphore.gr \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).