* [PATCH] cpufreq: intel_pstate: Remove unused member name of cpudata
@ 2014-05-20 18:12 Stratos Karafotis
2014-05-21 4:35 ` Viresh Kumar
2014-05-21 17:15 ` Dirk Brandewie
0 siblings, 2 replies; 3+ messages in thread
From: Stratos Karafotis @ 2014-05-20 18:12 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar, Dirk Brandewie
Cc: linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org >> LKML
Although, a value is assigned to member name of struct cpudata,
it is never used.
We can safely remove it.
Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
---
drivers/cpufreq/intel_pstate.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 24a534a..a6d5afa 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -88,8 +88,6 @@ struct _pid {
struct cpudata {
int cpu;
- char name[64];
-
struct timer_list timer;
struct pstate_data pstate;
@@ -544,8 +542,6 @@ static inline void intel_pstate_pstate_decrease(struct cpudata *cpu, int steps)
static void intel_pstate_get_cpu_pstates(struct cpudata *cpu)
{
- sprintf(cpu->name, "Intel 2nd generation core");
-
cpu->pstate.min_pstate = pstate_funcs.get_min();
cpu->pstate.max_pstate = pstate_funcs.get_max();
cpu->pstate.turbo_pstate = pstate_funcs.get_turbo();
--
1.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] cpufreq: intel_pstate: Remove unused member name of cpudata
2014-05-20 18:12 [PATCH] cpufreq: intel_pstate: Remove unused member name of cpudata Stratos Karafotis
@ 2014-05-21 4:35 ` Viresh Kumar
2014-05-21 17:15 ` Dirk Brandewie
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2014-05-21 4:35 UTC (permalink / raw)
To: Stratos Karafotis
Cc: Rafael J. Wysocki, Dirk Brandewie, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org >> LKML
On 20 May 2014 23:42, Stratos Karafotis <stratosk@semaphore.gr> wrote:
> Although, a value is assigned to member name of struct cpudata,
> it is never used.
>
> We can safely remove it.
>
> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
> ---
> drivers/cpufreq/intel_pstate.c | 4 ----
> 1 file changed, 4 deletions(-)
Looks fine to me atleast, lets see what Dirk will say :)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: intel_pstate: Remove unused member name of cpudata
2014-05-20 18:12 [PATCH] cpufreq: intel_pstate: Remove unused member name of cpudata Stratos Karafotis
2014-05-21 4:35 ` Viresh Kumar
@ 2014-05-21 17:15 ` Dirk Brandewie
1 sibling, 0 replies; 3+ messages in thread
From: Dirk Brandewie @ 2014-05-21 17:15 UTC (permalink / raw)
To: Stratos Karafotis, Rafael J. Wysocki, Viresh Kumar,
Dirk Brandewie
Cc: dirk.brandewie, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org >> LKML
On 05/20/2014 11:12 AM, Stratos Karafotis wrote:
> Although, a value is assigned to member name of struct cpudata,
> it is never used.
>
> We can safely remove it.
>
> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
Acked-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
> ---
> drivers/cpufreq/intel_pstate.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 24a534a..a6d5afa 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -88,8 +88,6 @@ struct _pid {
> struct cpudata {
> int cpu;
>
> - char name[64];
> -
> struct timer_list timer;
>
> struct pstate_data pstate;
> @@ -544,8 +542,6 @@ static inline void intel_pstate_pstate_decrease(struct cpudata *cpu, int steps)
>
> static void intel_pstate_get_cpu_pstates(struct cpudata *cpu)
> {
> - sprintf(cpu->name, "Intel 2nd generation core");
> -
> cpu->pstate.min_pstate = pstate_funcs.get_min();
> cpu->pstate.max_pstate = pstate_funcs.get_max();
> cpu->pstate.turbo_pstate = pstate_funcs.get_turbo();
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-21 17:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-20 18:12 [PATCH] cpufreq: intel_pstate: Remove unused member name of cpudata Stratos Karafotis
2014-05-21 4:35 ` Viresh Kumar
2014-05-21 17:15 ` Dirk Brandewie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).