linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stratos Karafotis <stratosk@semaphore.gr>
To: Dirk Brandewie <dirk.j.brandewie@intel.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Doug Smythies <dsmythies@telus.net>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Dirk Brandewie <dirk.brandewie@gmail.com>
Subject: Re: [PATCH 0/4] intel_pstate fixes for v3.16
Date: Fri, 30 May 2014 03:04:02 +0300	[thread overview]
Message-ID: <5387CAF2.9030508@semaphore.gr> (raw)
In-Reply-To: <CADmjqpNoRjhO=BaRBXxONCWd8-i9tzDLGVF4fTBs4jfRtHbdxw@mail.gmail.com>

On Thu, May 29, 2014 at 7:32 PM,  <dirk.brandewie@gmail.com> wrote:
> 
> From: Dirk Brandewie <dirk.j.brandewie@intel.com>
> 
> Based on Rafael's linux-next branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
> Commit 0c932c3ecbba60bc5f9e08d579891cdbedfdd1c1
> 
> Fixes the regression where intel_pstate was being too reactive
> reducing the P state caused by the C0 tracking which was added to
> ensure that on an idle system intel_pstate converge on the lowest
> reasonable P state.  The C0 tracking mechanism is replaced with a
> mechanism that looks at sample time and scales the busy calculation
> only if the sample time is *much* larger than the requested sample time.
> 
> Reference:
>    https://bugzilla.kernel.org/show_bug.cgi?id=75121
>    https://lkml.org/lkml/2014/5/6/597
> 
> Dirk Brandewie (3):
>   intel_pstate: Remove C0 tracking
>   intel_pstate: Correct rounding in busy calculation
>   intel_pstate: add sample time scaling
> 
> Doug Smythies (1):
>   intel_pstate: Improve initial busy calculation
> 
>  drivers/cpufreq/intel_pstate.c | 52 +++++++++++++++++++++++++-----------------
>  1 file changed, 31 insertions(+), 21 deletions(-)
> 

Hi,

I tested the patch set, run some benchmarks and I would like
to post the results:

CPU: Core i7-3770

			    TIME (sec)			ENERGY(J)
			Without	With	Diff	Without		With	  Diff
Phoronix kernel build	265.37	260.33	 -1.9%	15349.99	15437.57  +0.57%
Phoronix Apache		293.69	193.61	-34.8%	 9016.28	 8544.00  -5.24%
mp3 decoding 		245.64	245.91		 5057.73	 5046.07  -0.23%
Idle system (turbostat)  60	 60		 1210.80	 1211.40  +0.05%


In case you want to, you may add

Tested-by: Stratos Karafotis <stratosk@semaphore.gr>


Thanks,
Stratos

      parent reply	other threads:[~2014-05-30  0:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29 16:32 [PATCH 0/4] intel_pstate fixes for v3.16 dirk.brandewie
2014-05-29 16:32 ` [PATCH 1/4] intel_pstate: Remove C0 tracking dirk.brandewie
2014-05-29 16:32 ` [PATCH 2/4] intel_pstate: Correct rounding in busy calculation dirk.brandewie
2014-06-15 14:44   ` Doug Smythies
2014-06-15 22:46     ` Rafael J. Wysocki
2014-05-29 16:32 ` [PATCH 3/4] intel_pstate: add sample time scaling dirk.brandewie
2014-05-29 18:17   ` Yuyang Du
2014-06-09 15:58   ` Doug Smythies
2014-05-29 16:32 ` [PATCH 4/4] intel_pstate: Improve initial busy calculation dirk.brandewie
     [not found] ` <CADmjqpNoRjhO=BaRBXxONCWd8-i9tzDLGVF4fTBs4jfRtHbdxw@mail.gmail.com>
2014-05-30  0:04   ` Stratos Karafotis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5387CAF2.9030508@semaphore.gr \
    --to=stratosk@semaphore.gr \
    --cc=dirk.brandewie@gmail.com \
    --cc=dirk.j.brandewie@intel.com \
    --cc=dsmythies@telus.net \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).