From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Brandewie Subject: Re: [PATCH 1/7] cpufreq: intel_pstate: Remove duplicate CPU ID check Date: Tue, 10 Jun 2014 10:14:29 -0700 Message-ID: <53973CF5.4000201@intel.com> References: <53962059.6070306@semaphore.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Viresh Kumar , Stratos Karafotis Cc: dirk.j.brandewie@intel.com, "Rafael J. Wysocki" , "linux-pm@vger.kernel.org" , LKML List-Id: linux-pm@vger.kernel.org On 06/09/2014 10:21 PM, Viresh Kumar wrote: > On 10 June 2014 02:30, Stratos Karafotis wrote: >> We check the CPU ID during driver init. There is no need >> to do it again per logical CPU initialization. >> >> So, remove the duplicate check. >> >> Signed-off-by: Stratos Karafotis >> --- >> drivers/cpufreq/intel_pstate.c | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c >> index aebd457..4e7f492 100644 >> --- a/drivers/cpufreq/intel_pstate.c >> +++ b/drivers/cpufreq/intel_pstate.c >> @@ -691,14 +691,8 @@ MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids); >> >> static int intel_pstate_init_cpu(unsigned int cpunum) >> { >> - >> - const struct x86_cpu_id *id; >> struct cpudata *cpu; >> >> - id = x86_match_cpu(intel_pstate_cpu_ids); >> - if (!id) >> - return -ENODEV; >> - >> all_cpu_data[cpunum] = kzalloc(sizeof(struct cpudata), GFP_KERNEL); >> if (!all_cpu_data[cpunum]) >> return -ENOMEM; > > Acked-by: Viresh Kumar > Acked-by: Dirk Brandewie