From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Brandewie Subject: Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup Date: Tue, 10 Jun 2014 10:26:44 -0700 Message-ID: <53973FD4.7090904@intel.com> References: <5396208F.6070400@semaphore.gr> <53972070.3020608@intel.com> <1447217.dTmMAkaUnF@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pd0-f178.google.com ([209.85.192.178]:53394 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbaFJR0r (ORCPT ); Tue, 10 Jun 2014 13:26:47 -0400 In-Reply-To: <1447217.dTmMAkaUnF@vostro.rjw.lan> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "Rafael J. Wysocki" , Dirk Brandewie Cc: dirk.j.brandewie@intel.com, Stratos Karafotis , Viresh Kumar , "linux-pm@vger.kernel.org" , LKML On 06/10/2014 08:31 AM, Rafael J. Wysocki wrote: > On Tuesday, June 10, 2014 08:12:48 AM Dirk Brandewie wrote: >> On 06/09/2014 02:01 PM, Stratos Karafotis wrote: >>> Remove unnecessary blank lines. >>> Remove unnecessary parentheses. >>> Remove unnecessary braces. >>> Put the code in one line where possible. >>> Add blank lines after variable declarations. >>> Alignment to open parenthesis. >>> >> >> I don't have an issue with this patch in general but I would rather >> the cleanup be done when there is a functional change in the given >> hunk of code otherwise you are setting up a fence for stable/backporters >> of functional changes in the future. > > I actually prefer separate cleanups so as to avoid doing multiple things > in one patch. > > Rafael > I don't have strong feelings either way I was just trying to be kind to the maintainers of distro kernels.