Re: [PATCH 03/16] ARM: mvebu: Add function to export the physical address of the boot register

Thomas Petazzoni
2014-07-03T09:25:42Z

Dear Gregory CLEMENT,

On Thu, 03 Jul 2014 10:39:52 +0200, Gregory CLEMENT wrote:

> > I'm not sure that the best approach to solve this problem. Instead,
> > maybe the system-controller.c code should set up the boot address
> > workaround on Armada 375. Since the workaround on 375 is really related
> > to setting the boot address which is done by the system controller,
> > maybe the initialization of the workaround belongs in
> > system-controller.c ?
>
> So moving the workaround into mvebu_system_controller_set_cpu_boot_addr()
> should be the thing to do.

Except that mvebu_system_controller_set_cpu_boot_addr() is called
multiple times during the system execution, while you want the
workaround to be initialized once. And we surely don't really want a
static variable in there to test if the workaround has already been
initialized or not.

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering