Re: [PATCH 02/16] ARM: mvebu: Add a common function for the boot address work around

Thomas Petazzoni
2014-07-03T07:16:32Z

Gregory,

On Thu, 03 Jul 2014 00:58:22 +0200, Gregory CLEMENT wrote:

> >> +#define CRYPT0_ENG_ATTR 0x1
> >
> > For consistency, I'd prefer to see this being passed as argument to
> > mvebu_boot_addr_wa().
>
> The attribute is the same, so why bother with it? If later we have a SoC
> where this attribute can be different then I agree to add this argument.

Simply for consistency. MBus windows are defined by their target and
attribute values, so it makes sense to always pass both these values,
even if for the existing cases the attribute is for now always 0x1.

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering