linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Longnecker <mlongnecker@nvidia.com>
To: linux-kernel@vger.kernel.org
Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/6] ARM: tegra: Add soctherm and thermal zones to Tegra124 device tree
Date: Mon, 21 Jul 2014 16:12:41 -0700	[thread overview]
Message-ID: <53CD9E69.4000309@nvidia.com> (raw)
In-Reply-To: <1403856699-2140-5-git-send-email-mperttunen@nvidia.com>

On 6/27/2014 1:11 AM, Mikko Perttunen wrote:
> This adds the soctherm thermal sensing and management unit to the
> Tegra124 device tree along with the four thermal zones it exports.

Mikko, soctherm doesn't "export thermal zones". I would rewrite your 
desription like this:

   Extend the Tegra124 device tree by adding the soctherm thermal
   sensing and management unit and by defining four thermal zones --
   one for each temperature sensor in soctherm.

System integrators have some flexibility in deciding how many thermal 
zones to define for their platform. For example, an integrator could 
define a single zone for the entire Tegra chip (giving a simple system 
at runtime) or with multiple zones (giving potentially higher 
performance near thermal limits). That's why I don't like the 
implication that soctherm dictates the existence of particular thermal 
zones.

-Matt

  parent reply	other threads:[~2014-07-21 23:12 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-27  8:11 [PATCH 0/6] of-thermal hardware trip points + Tegra124 SOCTHERM driver Mikko Perttunen
2014-06-27  8:11 ` [PATCH 1/6] thermal: of: Add support for hardware-tracked trip points Mikko Perttunen
2014-06-30 21:08   ` Stephen Warren
2014-07-01  7:27     ` Mikko Perttunen
2014-07-01 18:15       ` Stephen Warren
2014-07-03 14:15         ` Mikko Perttunen
2014-07-21 23:53         ` Matthew Longnecker
2014-07-30 14:16   ` Eduardo Valentin
2014-08-01 11:42     ` Mikko Perttunen
     [not found]       ` <53DB7D0D.1070508-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-08-01 13:15         ` edubezval-Re5JQEeQqe8AvxtiuMwx3w
2014-06-27  8:11 ` [PATCH 2/6] of: Add bindings for nvidia,tegra124-soctherm Mikko Perttunen
     [not found]   ` <1403856699-2140-3-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-30 20:40     ` Stephen Warren
2014-06-27  8:11 ` [PATCH 3/6] ARM: tegra: Add thermal trip points for Jetson TK1 Mikko Perttunen
2014-06-30 20:45   ` Stephen Warren
2014-06-27  8:11 ` [PATCH 4/6] ARM: tegra: Add soctherm and thermal zones to Tegra124 device tree Mikko Perttunen
     [not found]   ` <1403856699-2140-5-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-30 20:48     ` Stephen Warren
2014-07-01  7:49       ` Mikko Perttunen
2014-07-21 23:12   ` Matthew Longnecker [this message]
2014-07-21 23:13   ` Matthew Longnecker
     [not found] ` <1403856699-2140-1-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-27  8:11   ` [PATCH 5/6] clk: tegra: Add soctherm and tsensor clocks to Tegra124 init table Mikko Perttunen
2014-06-27 12:18     ` Peter De Schrijver
2014-06-27  8:11 ` [PATCH 6/6] thermal: Add Tegra SOCTHERM thermal management driver Mikko Perttunen
2014-06-30 21:23   ` Stephen Warren
2014-07-01  8:06     ` Mikko Perttunen
     [not found]       ` <53B26BF2.7090009-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-07-01 18:26         ` Stephen Warren
2014-07-03 13:51           ` Mikko Perttunen
     [not found]   ` <1403856699-2140-7-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-07-01 23:47     ` Tuomas Tynkkynen
2014-07-04  8:43   ` Wei Ni
2014-07-04 11:52     ` Mikko Perttunen
2014-07-21  7:42 ` [PATCH 0/6] of-thermal hardware trip points + Tegra124 SOCTHERM driver Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CD9E69.4000309@nvidia.com \
    --to=mlongnecker@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).