From: Lan Tianyu <tianyu.lan@intel.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: rjw@rjwysocki.net, len.brown@intel.com, peterz@infradead.org,
toshi.kani@hp.com, mingo@kernel.org, akpm@linux-foundation.org,
todd.e.brandt@linux.intel.com, fabf@skynet.be,
srivatsa.bhat@linux.vnet.ibm.com, ego@linux.vnet.ibm.com,
rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [RFC PATCH] PM/CPU: Parallel enabling nonboot cpus with resume devices
Date: Thu, 24 Jul 2014 10:00:29 +0800 [thread overview]
Message-ID: <53D068BD.6090701@intel.com> (raw)
In-Reply-To: <20140723105304.GA22675@amd.pavel.ucw.cz>
On 2014年07月23日 18:53, Pavel Machek wrote:
> Hi!
>
>> In the current world, all nonboot cpus are enabled serially during system
>> resume. System resume sequence is that boot cpu enables nonboot cpu one by
>> one and then resume devices. Before resuming devices, there are few tasks
>> assigned to nonboot cpus after they are brought up. This waste cpu usage.
>>
>> To accelerate S3, this patches adds a new kernel configure
>> PM_PARALLEL_CPU_UP_FOR_SUSPEND to allow boot cpu to go forward to resume
>> devices after bringing up one nonboot cpu. The nonboot cpu will be in charge
>> of bringing up other cpus. This makes enabling cpu2~x parallel with resuming
>> devices. From the test result on 4 logical core laptop, the time of resume
>> device almost wasn't affected by enabling nonboot cpus lately while the start
>> point is almost 30ms earlier than before.
>
> Does this mean that userspace can now run seeing the "offlined" cpus
> still in offline state?
No, the PM event handler of cpu hotplug will reenable cpu hotplug via
cpu_hotplug_enable() at the end of system resume. The function will wait
for currently running cpu hotplug operations to complete.
>
> Pavel
>
--
Best regards
Tianyu Lan
next prev parent reply other threads:[~2014-07-24 2:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 9:11 [RFC PATCH] PM/CPU: Parallel enabling nonboot cpus with resume devices Lan Tianyu
2014-07-23 9:21 ` Peter Zijlstra
2014-07-23 9:48 ` Lan Tianyu
2014-07-23 10:53 ` Pavel Machek
2014-07-24 2:00 ` Lan Tianyu [this message]
2014-08-08 10:55 ` Gautham R Shenoy
2014-08-11 8:50 ` Lan Tianyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D068BD.6090701@intel.com \
--to=tianyu.lan@intel.com \
--cc=akpm@linux-foundation.org \
--cc=ego@linux.vnet.ibm.com \
--cc=fabf@skynet.be \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=todd.e.brandt@linux.intel.com \
--cc=toshi.kani@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).