From: Juri Lelli <juri.lelli@arm.com>
To: Kevin Hilman <khilman@linaro.org>
Cc: "linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Will Deacon <Will.Deacon@arm.com>,
Chao Xie <chao.xie@marvell.com>,
Stephen Warren <swarren@nvidia.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
Jonathan Austin <Jonathan.Austin@arm.com>,
Chao Xie Linux <xiechao.mail@gmail.com>,
Juri Lelli <juri.lelli@gmail.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] cpuidle/cpuidle-big_little: fix reading cpu id part number
Date: Fri, 15 Aug 2014 17:36:05 +0100 [thread overview]
Message-ID: <53EE36F5.7000801@arm.com> (raw)
In-Reply-To: <7hwqa9ww6n.fsf@paris.lan>
On 15/08/14 17:32, Kevin Hilman wrote:
> Juri Lelli <juri.lelli@arm.com> writes:
>
>> Commit af040ffc9ba1 ("ARM: make it easier to check the CPU part number
>> correctly") changed ARM_CPU_PART_X masks, and the way they are returned and
>> checked against. Usage of read_cpuid_part_number() is now deprecated, and
>> calling places updated accordingly. This actually broke cpuidle-big_little
>> initialization, as bl_idle_driver_init() performs a check using an hardcoded
>> mask on cpu_id.
>>
>> Create an interface to perform the check (that is now even easier to read).
>> Define also a proper mask (ARM_CPU_PART_MASK) that makes this kind of checks
>> cleaner and helps preventing bugs in the future. Update usage accordingly.
>
> [...]
>
> Tested-by: Kevin Hilman <khilman@linaro.org>
>
Great, thanks!
> FWIW, I can confirm that this patch is needed for cpuidle-big_little to
> work on the Exynos5800/Chromebook2.
>
Ok, the patch has been already sent to Russell's patch system.
Best,
- Juri
> Kevin
>
prev parent reply other threads:[~2014-08-15 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 8:27 [PATCH v2] cpuidle/cpuidle-big_little: fix reading cpu id part number Juri Lelli
2014-08-15 10:07 ` Lorenzo Pieralisi
2014-08-15 16:32 ` Kevin Hilman
2014-08-15 16:36 ` Juri Lelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EE36F5.7000801@arm.com \
--to=juri.lelli@arm.com \
--cc=Jonathan.Austin@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=Will.Deacon@arm.com \
--cc=chao.xie@marvell.com \
--cc=daniel.lezcano@linaro.org \
--cc=juri.lelli@gmail.com \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rjw@rjwysocki.net \
--cc=rob.herring@calxeda.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=swarren@nvidia.com \
--cc=xiechao.mail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).