linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rafael Wysocki <rjw@rjwysocki.net>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
	prarit@redhat.com, skannan@codeaurora.org,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH V2 07/14] cpufreq: stats: remove cpufreq_stats_update_policy_cpu()
Date: Fri,  2 Jan 2015 11:16:44 +0530	[thread overview]
Message-ID: <53e8e4e9a40d2759ebdecfe4649f9ecee112a330.1420177186.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1420177186.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1420177186.git.viresh.kumar@linaro.org>

cpufreq_stats_update_policy_cpu() doesn't do any useful stuff anymore and must
be removed. Along with it, also remove 'cpu' field from 'struct cpufreq_stats'
as that isn't used as well.

Reviewed-by: Prarit Bhargava <prarit@redhat.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/cpufreq/cpufreq_stats.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
index 106c89ccef30..f458fdbc5bfd 100644
--- a/drivers/cpufreq/cpufreq_stats.c
+++ b/drivers/cpufreq/cpufreq_stats.c
@@ -18,7 +18,6 @@
 static spinlock_t cpufreq_stats_lock;
 
 struct cpufreq_stats {
-	unsigned int cpu;
 	unsigned int total_trans;
 	unsigned long long last_time;
 	unsigned int max_state;
@@ -194,7 +193,6 @@ static int __cpufreq_stats_create_table(struct cpufreq_policy *policy)
 	if (ret)
 		goto error_out;
 
-	stat->cpu = cpu;
 	policy->stats_data = stat;
 
 	cpufreq_for_each_valid_entry(pos, table)
@@ -251,24 +249,12 @@ static void cpufreq_stats_create_table(unsigned int cpu)
 	cpufreq_cpu_put(policy);
 }
 
-static void cpufreq_stats_update_policy_cpu(struct cpufreq_policy *policy)
-{
-	struct cpufreq_stats *stat = policy->stats_data;
-
-	stat->cpu = policy->cpu;
-}
-
 static int cpufreq_stat_notifier_policy(struct notifier_block *nb,
 		unsigned long val, void *data)
 {
 	int ret = 0;
 	struct cpufreq_policy *policy = data;
 
-	if (val == CPUFREQ_UPDATE_POLICY_CPU) {
-		cpufreq_stats_update_policy_cpu(policy);
-		return 0;
-	}
-
 	if (val == CPUFREQ_CREATE_POLICY)
 		ret = __cpufreq_stats_create_table(policy);
 	else if (val == CPUFREQ_REMOVE_POLICY)
-- 
2.2.0


  parent reply	other threads:[~2015-01-02  5:47 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-02  5:46 [PATCH V2 00/14] cpufreq: stats: cleanups Viresh Kumar
2015-01-02  5:46 ` [PATCH V2 01/14] cpufreq: stats: don't break strings into multiple lines Viresh Kumar
2015-01-03 21:57   ` Rafael J. Wysocki
2015-01-04  3:15     ` Viresh Kumar
2015-01-02  5:46 ` [PATCH V2 02/14] cpufreq: stats: return -EEXIST when stats are already allocated Viresh Kumar
2015-01-03 21:58   ` Rafael J. Wysocki
2015-01-04  3:18     ` Viresh Kumar
2015-01-05 23:52       ` Rafael J. Wysocki
2015-01-06  3:42         ` Viresh Kumar
2015-01-02  5:46 ` [PATCH V2 03/14] cpufreq: stats: don't check for freq table while freeing stats Viresh Kumar
2015-01-02  5:46 ` [PATCH V2 04/14] cpufreq: stats: pass 'stat' to cpufreq_stats_update() Viresh Kumar
2015-01-03 22:04   ` Rafael J. Wysocki
2015-01-05  4:04     ` Viresh Kumar
     [not found]       ` <OF5E9CEA82.619493CC-ONC1257DC4.0027BC08-C1257DC4.0027BC14@lonatigroup.com>
2015-01-05  7:25         ` [PATCH V2 04/14] cpufreq: stats: pass 'stat' to cpufreq_stats_update() * Viresh Kumar
2015-01-02  5:46 ` [PATCH V2 05/14] cpufreq: stats: get rid of per-cpu cpufreq_stats_table Viresh Kumar
2015-01-03 22:20   ` Rafael J. Wysocki
2015-01-05  4:23     ` Viresh Kumar
2015-01-05 23:38       ` Rafael J. Wysocki
2015-01-02  5:46 ` [PATCH V2 06/14] cpufreq: Remove (now) unused 'last_cpu' from struct cpufreq_policy Viresh Kumar
2015-01-02  5:46 ` Viresh Kumar [this message]
2015-01-03 22:25   ` [PATCH V2 07/14] cpufreq: stats: remove cpufreq_stats_update_policy_cpu() Rafael J. Wysocki
2015-01-05  4:26     ` Viresh Kumar
2015-01-02  5:46 ` [PATCH V2 08/14] cpufreq: remove CPUFREQ_UPDATE_POLICY_CPU notifications Viresh Kumar
2015-01-03 22:28   ` Rafael J. Wysocki
2015-01-05  4:27     ` Viresh Kumar
2015-01-02  5:46 ` [PATCH V2 09/14] cpufreq: stats: create sysfs group once we are ready Viresh Kumar
2015-01-02  5:46 ` [PATCH V2 10/14] cpufreq: stats: don't update stats from show_trans_table() Viresh Kumar
2015-01-02  5:46 ` [PATCH V2 11/14] cpufreq: stats: don't update stats on false notifiers Viresh Kumar
2015-01-03 22:36   ` Rafael J. Wysocki
2015-01-02  5:46 ` [PATCH V2 12/14] cpufreq: stats: replace spinlock with mutex Viresh Kumar
2015-01-03 22:38   ` Rafael J. Wysocki
2015-01-02  5:46 ` [PATCH V2 13/14] cpufreq: stats: Fix locking Viresh Kumar
2015-01-03 22:43   ` Rafael J. Wysocki
2015-01-05  8:06     ` Viresh Kumar
2015-01-05 23:35       ` Rafael J. Wysocki
2015-01-06  3:34         ` Viresh Kumar
2015-01-02  5:46 ` [PATCH V2 14/14] cpufreq: stats: call cpufreq_stats_update() with locks held Viresh Kumar
2015-01-03 22:48   ` Rafael J. Wysocki
2015-01-02 13:08 ` [PATCH V2 00/14] cpufreq: stats: cleanups Prarit Bhargava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53e8e4e9a40d2759ebdecfe4649f9ecee112a330.1420177186.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=prarit@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=skannan@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).