From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCHv5 4/4] thermal: exynos: Remove duplicate code when reading triminfo register of Exynos5440 Date: Wed, 03 Sep 2014 11:08:43 +0900 Message-ID: <5406782B.9000408@samsung.com> References: <1409016665-3824-1-git-send-email-cw00.choi@samsung.com> <1409016665-3824-5-git-send-email-cw00.choi@samsung.com> <53FEAF2A.1080400@samsung.com> <20140828145310.GC18194@developer> <53FFC051.7040907@samsung.com> <20140829192818.GB23645@developer> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:24357 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105AbaICCIq (ORCPT ); Tue, 2 Sep 2014 22:08:46 -0400 In-reply-to: <20140829192818.GB23645@developer> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Eduardo Valentin Cc: eduardo.valentin@ti.com, amit.daniel@samsung.com, rui.zhang@intel.com, kgene.kim@samsung.com, ch.naveen@samsung.com, kyungmin.park@samsung.com, b.zolnierkie@samsung.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Dear Eduardo, On 08/30/2014 04:28 AM, Eduardo Valentin wrote: > Chanwoo, > > On Fri, Aug 29, 2014 at 08:50:41AM +0900, Chanwoo Choi wrote: >> Dear Eduardo, >> >> On 08/28/2014 11:53 PM, Eduardo Valentin wrote: >>> On Thu, Aug 28, 2014 at 01:25:14PM +0900, Chanwoo Choi wrote: >>>> Dear Eduardo, >>>> >>>> This patch is wrong. It is my mistake. >>>> >>>> Please ignore only this patch because >>>> the offset calculation of 'case 0' is different from 'case 2'. >>> >>> >>> Do patches 1 - 3 are still correct? Patch 1, from Barlomiej, seams to be >>> a common agreement. > >> >> Yes, patches 1 - 3 are correct. >> > > OK. I pulled patch 01 into my next branch. > > Can you please update patches 02 and 03 based on my next brach? They are > conflicting with the massive cleanups done by Bartlomiej (Thanks > Bartlomiej). So, please, resend patches 02 and 03 only, refreshed onto > my next branch. OK, I'll send new patchset after rebase it. Best Regards, Chanwoo Choi > > Cheers. > >> Best Regards, >> Chanwoo Choi >> >>> >>>> >>>> Best Regards, >>>> Chanwoo Choi >>>> >>>> On 08/26/2014 10:31 AM, Chanwoo Choi wrote: >>>>> This patch remove simply duplicate code when reading triminfo register of Exynos5440. >>>>> >>>>> Signed-off-by: Chanwoo Choi >>>>> Acked-by: Kyungmin Park >>>>> Cc: Zhang Rui >>>>> Cc: Eduardo Valentin >>>>> Cc: Amit Daniel Kachhap >>>>> Reviewed-by: Amit Daniel Kachhap >>>>> --- >>>>> drivers/thermal/samsung/exynos_tmu.c | 4 +--- >>>>> 1 file changed, 1 insertion(+), 3 deletions(-) >>>>> >>>>> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c >>>>> index 64c702a..5888467 100644 >>>>> --- a/drivers/thermal/samsung/exynos_tmu.c >>>>> +++ b/drivers/thermal/samsung/exynos_tmu.c >>>>> @@ -187,15 +187,13 @@ static int exynos_tmu_initialize(struct platform_device *pdev) >>>>> */ >>>>> switch (data->id) { >>>>> case 0: >>>>> + case 2: >>>>> trim_info = readl(data->base + >>>>> EXYNOS5440_EFUSE_SWAP_OFFSET + reg->triminfo_data); >>>>> break; >>>>> case 1: >>>>> trim_info = readl(data->base + reg->triminfo_data); >>>>> break; >>>>> - case 2: >>>>> - trim_info = readl(data->base - >>>>> - EXYNOS5440_EFUSE_SWAP_OFFSET + reg->triminfo_data); >>>>> } >>>>> } else { >>>>> /* On exynos5420 the triminfo register is in the shared space */ >>>>> >>>> >>> >> >