From: Francis Moreau <francis.moro@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, linux-pm@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH 3.10.y+] PM / sleep: Use valid_state() for platform-dependent sleep states only
Date: Fri, 05 Sep 2014 08:29:09 +0200 [thread overview]
Message-ID: <54095835.7000207@gmail.com> (raw)
In-Reply-To: <1409865665-5375-1-git-send-email-computersforpeace@gmail.com>
Hello,
On 09/04/2014 11:21 PM, Brian Norris wrote:
> From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
>
> [Upstream commit 43e8317b0bba1d6eb85f38a4a233d82d7c20d732]
>
> Use the observation that, for platform-dependent sleep states
> (PM_SUSPEND_STANDBY, PM_SUSPEND_MEM), a given state is either
> always supported or always unsupported and store that information
> in pm_states[] instead of calling valid_state() every time we
> need to check it.
>
> Also do not use valid_state() for PM_SUSPEND_FREEZE, which is always
> valid, and move the pm_test_level validity check for PM_SUSPEND_FREEZE
> directly into enter_state().
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: <stable@vger.kernel.org> # 3.10+: 27ddcc6596e5: PM / sleep: Add state field to pm_states[] entries
> Cc: <stable@vger.kernel.org> # 3.10+
> ---
> This is a backport request for these two commits upstream:
>
> 27ddcc6596e5 PM / sleep: Add state field to pm_states[] entries
> 43e8317b0bba PM / sleep: Use valid_state() for platform-dependent sleep states only
>
Wouldn't it be cleaner to have 2 separate backports then ?
Thanks for the backport anyways.
next prev parent reply other threads:[~2014-09-05 6:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 1:02 [stable -3.14] PM backports for pm_test / CONFIG_PM_DEBUG Brian Norris
2014-09-04 19:40 ` Rafael J. Wysocki
2014-09-04 21:14 ` Brian Norris
2014-09-04 21:21 ` [PATCH 3.10.y+] PM / sleep: Use valid_state() for platform-dependent sleep states only Brian Norris
2014-09-05 6:29 ` Francis Moreau [this message]
2014-09-05 7:45 ` Brian Norris
2014-09-05 14:52 ` Francis Moreau
2014-09-05 21:47 ` Greg Kroah-Hartman
2014-09-05 22:08 ` Brian Norris
2014-09-05 22:36 ` Greg Kroah-Hartman
2014-09-05 22:45 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54095835.7000207@gmail.com \
--to=francis.moro@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).