From: Rik van Riel <riel@redhat.com>
To: Nicolas Pitre <nicolas.pitre@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH v2 2/2] sched/fair: leverage the idle state info when choosing the "idlest" cpu
Date: Tue, 30 Sep 2014 17:58:21 -0400 [thread overview]
Message-ID: <542B277D.7050103@redhat.com> (raw)
In-Reply-To: <1409844730-12273-3-git-send-email-nicolas.pitre@linaro.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 09/04/2014 11:32 AM, Nicolas Pitre wrote:
> The code in find_idlest_cpu() looks for the CPU with the smallest
> load. However, if multiple CPUs are idle, the first idle CPU is
> selected irrespective of the depth of its idle state.
>
> Among the idle CPUs we should pick the one with with the shallowest
> idle state, or the latest to have gone idle if all idle CPUs are in
> the same state. The later applies even when cpuidle is configured
> out.
>
> This patch doesn't cover the following issues:
The main thing it does not cover is already running tasks that
get woken up again, since select_idle_sibling() covers everything
except for newly forked and newly executed tasks.
I am looking at adding similar logic to select_idle_sibling()
- --
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJUKyd9AAoJEM553pKExN6DXZgH/1R26XfYv2FzYV9IGbty3vVx
1kMPozdb7jRAUR8+WkUgs7ntkbqau2hC/nTjDsSsiLQwXdjaDdqvnbt8Y6srI1es
/Z+IRaIPGx24D7D6nB5sLgsAq6DsANUdtFK3TsED8+07LbiY71o64YQ3X1IEVyRO
FKBcDw9+DBPGVySKIdMm0h2txdnQ3Jy2lM3nKV8tBFheRuOhU4Rv/fumEYAUYvDV
J9y91RhKOeEJYmaYL6oQYtZgBqhDoJmh/0DjOrK6H71oZYiNWeIUxtieNXaNQp7B
Rd8khOVFLsf/qZK6qjmgnfO9Mm5ij/PvrALOBZt8O9KAD3/v3kXfWIm9tO1NDZU=
=kTdn
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-09-30 21:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 15:32 [PATCH v2 0/2] sched/idle : find the best idle CPU with cpuidle info Nicolas Pitre
2014-09-04 15:32 ` [PATCH v2 1/2] sched: let the scheduler see CPU idle states Nicolas Pitre
2014-09-18 17:37 ` Paul E. McKenney
2014-09-18 17:39 ` Paul E. McKenney
2014-09-18 23:15 ` Peter Zijlstra
2014-09-18 18:32 ` Nicolas Pitre
2014-09-18 23:17 ` Peter Zijlstra
2014-09-18 23:28 ` Peter Zijlstra
2014-09-19 18:30 ` Nicolas Pitre
2014-09-04 15:32 ` [PATCH v2 2/2] sched/fair: leverage the idle state info when choosing the "idlest" cpu Nicolas Pitre
2014-09-05 7:52 ` Daniel Lezcano
2014-09-18 23:46 ` Peter Zijlstra
2014-09-19 0:05 ` Peter Zijlstra
2014-09-19 4:49 ` Yao Dongdong
2014-09-30 21:58 ` Rik van Riel [this message]
2014-09-30 23:15 ` Nicolas Pitre
2014-10-02 17:15 ` [PATCH RFC] sched,idle: teach select_idle_sibling about idle states Rik van Riel
2014-10-03 6:04 ` Mike Galbraith
2014-10-03 6:23 ` Mike Galbraith
2014-10-03 7:50 ` Peter Zijlstra
2014-10-03 13:05 ` Mike Galbraith
2014-10-03 14:28 ` Rik van Riel
2014-10-03 14:46 ` Peter Zijlstra
2014-10-03 15:37 ` Rik van Riel
2014-10-09 16:04 ` Peter Zijlstra
2014-10-03 18:52 ` Nicolas Pitre
2014-09-10 21:35 ` [PATCH v2 0/2] sched/idle : find the best idle CPU with cpuidle info Nicolas Pitre
2014-09-10 22:50 ` Rafael J. Wysocki
2014-09-10 23:25 ` Nicolas Pitre
2014-09-10 23:28 ` Nicolas Pitre
2014-09-10 23:50 ` Rafael J. Wysocki
2014-09-18 0:39 ` Nicolas Pitre
2014-09-18 23:24 ` Peter Zijlstra
2014-09-19 18:22 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542B277D.7050103@redhat.com \
--to=riel@redhat.com \
--cc=daniel.lezcano@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nicolas.pitre@linaro.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).