* Re: [PATCH] drivers: base: power: domain: Use 'pm_cpu_data' instead of 'cpu_data' for compiling break
2014-10-04 14:19 [PATCH] drivers: base: power: domain: Use 'pm_cpu_data' instead of 'cpu_data' for compiling break Chen Gang
@ 2014-10-04 14:20 ` Chen Gang
2014-10-04 16:00 ` Greg KH
2014-10-05 21:32 ` Rafael J. Wysocki
2 siblings, 0 replies; 11+ messages in thread
From: Chen Gang @ 2014-10-04 14:20 UTC (permalink / raw)
To: rjw, pavel, len.brown, gregkh, ulf.hansson, khilman,
geert+renesas, tomasz.figa, richard
Cc: linux-pm, linux-kernel
After this patch, our um can pass allmodconfig compiling.
Thanks.
On 10/4/14 22:19, Chen Gang wrote:
> 'cpu_data' is too common to be already used by some architectures (e.g.
> um, m32r, and mn10300), so need use 'pm_cpu_data' instead of, or cause
> compiling break. The related error (with allmodconfig under um):
>
> CC drivers/base/platform.o
> In file included from ./arch/x86/um/asm/processor.h:31:0,
> from ./arch/um/include/asm/uaccess.h:16,
> from ./arch/um/include/asm/thread_info.h:13,
> from include/linux/thread_info.h:54,
> from include/asm-generic/current.h:4,
> from arch/um/include/generated/asm/current.h:1,
> from include/linux/mutex.h:13,
> from include/linux/kernfs.h:13,
> from include/linux/sysfs.h:15,
> from include/linux/kobject.h:21,
> from include/linux/device.h:17,
> from include/linux/platform_device.h:14,
> from drivers/base/platform.c:14:
> ./arch/um/include/asm/processor-generic.h:107:19: error: expected identifier or '(' before '&' token
> #define cpu_data (&boot_cpu_data)
> ^
> include/linux/pm_domain.h:74:23: note: in expansion of macro 'cpu_data'
> struct gpd_cpu_data *cpu_data;
> ^
>
> Also need notice about 80 columns boundary.
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> drivers/base/power/domain.c | 54 ++++++++++++++++++++++-----------------------
> include/linux/pm_domain.h | 2 +-
> 2 files changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 18cc68d..d8d2739 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -142,13 +142,13 @@ static void genpd_recalc_cpu_exit_latency(struct generic_pm_domain *genpd)
> {
> s64 usecs64;
>
> - if (!genpd->cpu_data)
> + if (!genpd->pm_cpu_data)
> return;
>
> usecs64 = genpd->power_on_latency_ns;
> do_div(usecs64, NSEC_PER_USEC);
> - usecs64 += genpd->cpu_data->saved_exit_latency;
> - genpd->cpu_data->idle_state->exit_latency = usecs64;
> + usecs64 += genpd->pm_cpu_data->saved_exit_latency;
> + genpd->pm_cpu_data->idle_state->exit_latency = usecs64;
> }
>
> /**
> @@ -188,9 +188,9 @@ static int __pm_genpd_poweron(struct generic_pm_domain *genpd)
> return 0;
> }
>
> - if (genpd->cpu_data) {
> + if (genpd->pm_cpu_data) {
> cpuidle_pause_and_lock();
> - genpd->cpu_data->idle_state->disabled = true;
> + genpd->pm_cpu_data->idle_state->disabled = true;
> cpuidle_resume_and_unlock();
> goto out;
> }
> @@ -513,17 +513,17 @@ static int pm_genpd_poweroff(struct generic_pm_domain *genpd)
> }
> }
>
> - if (genpd->cpu_data) {
> + if (genpd->pm_cpu_data) {
> /*
> - * If cpu_data is set, cpuidle should turn the domain off when
> - * the CPU in it is idle. In that case we don't decrement the
> - * subdomain counts of the master domains, so that power is not
> - * removed from the current domain prematurely as a result of
> - * cutting off the masters' power.
> + * If pm_cpu_data is set, cpuidle should turn the domain off
> + * when the CPU in it is idle. In that case we don't decrement
> + * the subdomain counts of the master domains, so that power is
> + * not removed from the current domain prematurely as a result
> + * of cutting off the masters' power.
> */
> genpd->status = GPD_STATE_POWER_OFF;
> cpuidle_pause_and_lock();
> - genpd->cpu_data->idle_state->disabled = false;
> + genpd->pm_cpu_data->idle_state->disabled = false;
> cpuidle_resume_and_unlock();
> goto out;
> }
> @@ -1698,7 +1698,7 @@ int pm_genpd_remove_subdomain(struct generic_pm_domain *genpd,
> int pm_genpd_attach_cpuidle(struct generic_pm_domain *genpd, int state)
> {
> struct cpuidle_driver *cpuidle_drv;
> - struct gpd_cpu_data *cpu_data;
> + struct gpd_cpu_data *pm_cpu_data;
> struct cpuidle_state *idle_state;
> int ret = 0;
>
> @@ -1707,12 +1707,12 @@ int pm_genpd_attach_cpuidle(struct generic_pm_domain *genpd, int state)
>
> genpd_acquire_lock(genpd);
>
> - if (genpd->cpu_data) {
> + if (genpd->pm_cpu_data) {
> ret = -EEXIST;
> goto out;
> }
> - cpu_data = kzalloc(sizeof(*cpu_data), GFP_KERNEL);
> - if (!cpu_data) {
> + pm_cpu_data = kzalloc(sizeof(*pm_cpu_data), GFP_KERNEL);
> + if (!pm_cpu_data) {
> ret = -ENOMEM;
> goto out;
> }
> @@ -1730,9 +1730,9 @@ int pm_genpd_attach_cpuidle(struct generic_pm_domain *genpd, int state)
> ret = -EAGAIN;
> goto err;
> }
> - cpu_data->idle_state = idle_state;
> - cpu_data->saved_exit_latency = idle_state->exit_latency;
> - genpd->cpu_data = cpu_data;
> + pm_cpu_data->idle_state = idle_state;
> + pm_cpu_data->saved_exit_latency = idle_state->exit_latency;
> + genpd->pm_cpu_data = pm_cpu_data;
> genpd_recalc_cpu_exit_latency(genpd);
>
> out:
> @@ -1743,7 +1743,7 @@ int pm_genpd_attach_cpuidle(struct generic_pm_domain *genpd, int state)
> cpuidle_driver_unref();
>
> err_drv:
> - kfree(cpu_data);
> + kfree(pm_cpu_data);
> goto out;
> }
>
> @@ -1766,7 +1766,7 @@ int pm_genpd_name_attach_cpuidle(const char *name, int state)
> */
> int pm_genpd_detach_cpuidle(struct generic_pm_domain *genpd)
> {
> - struct gpd_cpu_data *cpu_data;
> + struct gpd_cpu_data *pm_cpu_data;
> struct cpuidle_state *idle_state;
> int ret = 0;
>
> @@ -1775,20 +1775,20 @@ int pm_genpd_detach_cpuidle(struct generic_pm_domain *genpd)
>
> genpd_acquire_lock(genpd);
>
> - cpu_data = genpd->cpu_data;
> - if (!cpu_data) {
> + pm_cpu_data = genpd->pm_cpu_data;
> + if (!pm_cpu_data) {
> ret = -ENODEV;
> goto out;
> }
> - idle_state = cpu_data->idle_state;
> + idle_state = pm_cpu_data->idle_state;
> if (!idle_state->disabled) {
> ret = -EAGAIN;
> goto out;
> }
> - idle_state->exit_latency = cpu_data->saved_exit_latency;
> + idle_state->exit_latency = pm_cpu_data->saved_exit_latency;
> cpuidle_driver_unref();
> - genpd->cpu_data = NULL;
> - kfree(cpu_data);
> + genpd->pm_cpu_data = NULL;
> + kfree(pm_cpu_data);
>
> out:
> genpd_release_lock(genpd);
> diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
> index 9004743..a73b825 100644
> --- a/include/linux/pm_domain.h
> +++ b/include/linux/pm_domain.h
> @@ -71,7 +71,7 @@ struct generic_pm_domain {
> s64 max_off_time_ns; /* Maximum allowed "suspended" time. */
> bool max_off_time_changed;
> bool cached_power_down_ok;
> - struct gpd_cpu_data *cpu_data;
> + struct gpd_cpu_data *pm_cpu_data;
> void (*attach_dev)(struct device *dev);
> void (*detach_dev)(struct device *dev);
> };
>
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] drivers: base: power: domain: Use 'pm_cpu_data' instead of 'cpu_data' for compiling break
2014-10-04 14:19 [PATCH] drivers: base: power: domain: Use 'pm_cpu_data' instead of 'cpu_data' for compiling break Chen Gang
2014-10-04 14:20 ` Chen Gang
@ 2014-10-04 16:00 ` Greg KH
2014-10-05 1:13 ` Chen Gang
2014-10-05 2:42 ` Randy Dunlap
2014-10-05 21:32 ` Rafael J. Wysocki
2 siblings, 2 replies; 11+ messages in thread
From: Greg KH @ 2014-10-04 16:00 UTC (permalink / raw)
To: Chen Gang
Cc: rjw, pavel, len.brown, ulf.hansson, khilman, geert+renesas,
tomasz.figa, richard, linux-pm, linux-kernel
On Sat, Oct 04, 2014 at 10:19:50PM +0800, Chen Gang wrote:
> 'cpu_data' is too common to be already used by some architectures (e.g.
> um, m32r, and mn10300), so need use 'pm_cpu_data' instead of, or cause
> compiling break. The related error (with allmodconfig under um):
>
> CC drivers/base/platform.o
> In file included from ./arch/x86/um/asm/processor.h:31:0,
> from ./arch/um/include/asm/uaccess.h:16,
> from ./arch/um/include/asm/thread_info.h:13,
> from include/linux/thread_info.h:54,
> from include/asm-generic/current.h:4,
> from arch/um/include/generated/asm/current.h:1,
> from include/linux/mutex.h:13,
> from include/linux/kernfs.h:13,
> from include/linux/sysfs.h:15,
> from include/linux/kobject.h:21,
> from include/linux/device.h:17,
> from include/linux/platform_device.h:14,
> from drivers/base/platform.c:14:
> ./arch/um/include/asm/processor-generic.h:107:19: error: expected identifier or '(' before '&' token
> #define cpu_data (&boot_cpu_data)
> ^
> include/linux/pm_domain.h:74:23: note: in expansion of macro 'cpu_data'
> struct gpd_cpu_data *cpu_data;
> ^
>
> Also need notice about 80 columns boundary.
I don't object to this change at all, but it could be easier to solve
this by fixing up 'cpu_data' to be named something a bit less "generic"?
What does x86 use for this data type?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] drivers: base: power: domain: Use 'pm_cpu_data' instead of 'cpu_data' for compiling break
2014-10-04 16:00 ` Greg KH
@ 2014-10-05 1:13 ` Chen Gang
2014-10-05 1:23 ` Greg KH
2014-10-05 1:31 ` Chen Gang
2014-10-05 2:42 ` Randy Dunlap
1 sibling, 2 replies; 11+ messages in thread
From: Chen Gang @ 2014-10-05 1:13 UTC (permalink / raw)
To: Greg KH
Cc: rjw, pavel, len.brown, ulf.hansson, khilman, geert+renesas,
tomasz.figa, richard, linux-pm, linux-kernel
On 10/5/14 0:00, Greg KH wrote:
> On Sat, Oct 04, 2014 at 10:19:50PM +0800, Chen Gang wrote:
>> 'cpu_data' is too common to be already used by some architectures (e.g.
>> um, m32r, and mn10300), so need use 'pm_cpu_data' instead of, or cause
>> compiling break. The related error (with allmodconfig under um):
>>
>> CC drivers/base/platform.o
>> In file included from ./arch/x86/um/asm/processor.h:31:0,
>> from ./arch/um/include/asm/uaccess.h:16,
>> from ./arch/um/include/asm/thread_info.h:13,
>> from include/linux/thread_info.h:54,
>> from include/asm-generic/current.h:4,
>> from arch/um/include/generated/asm/current.h:1,
>> from include/linux/mutex.h:13,
>> from include/linux/kernfs.h:13,
>> from include/linux/sysfs.h:15,
>> from include/linux/kobject.h:21,
>> from include/linux/device.h:17,
>> from include/linux/platform_device.h:14,
>> from drivers/base/platform.c:14:
>> ./arch/um/include/asm/processor-generic.h:107:19: error: expected identifier or '(' before '&' token
>> #define cpu_data (&boot_cpu_data)
>> ^
>> include/linux/pm_domain.h:74:23: note: in expansion of macro 'cpu_data'
>> struct gpd_cpu_data *cpu_data;
>> ^
>>
>> Also need notice about 80 columns boundary.
>
> I don't object to this change at all, but it could be easier to solve
> this by fixing up 'cpu_data' to be named something a bit less "generic"?
> What does x86 use for this data type?
>
It is for some kinds of arm cpu (I let this patch pass arm s3c600
def_config building). Other architectures did not use it, at present.
If necessary to complete the comments, please let me know, I shall send
patch v2 for it.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] drivers: base: power: domain: Use 'pm_cpu_data' instead of 'cpu_data' for compiling break
2014-10-05 1:13 ` Chen Gang
@ 2014-10-05 1:23 ` Greg KH
2014-10-05 2:11 ` Chen Gang
2014-10-05 1:31 ` Chen Gang
1 sibling, 1 reply; 11+ messages in thread
From: Greg KH @ 2014-10-05 1:23 UTC (permalink / raw)
To: Chen Gang
Cc: rjw, pavel, len.brown, ulf.hansson, khilman, geert+renesas,
tomasz.figa, richard, linux-pm, linux-kernel
On Sun, Oct 05, 2014 at 09:13:09AM +0800, Chen Gang wrote:
> On 10/5/14 0:00, Greg KH wrote:
> > On Sat, Oct 04, 2014 at 10:19:50PM +0800, Chen Gang wrote:
> >> 'cpu_data' is too common to be already used by some architectures (e.g.
> >> um, m32r, and mn10300), so need use 'pm_cpu_data' instead of, or cause
> >> compiling break. The related error (with allmodconfig under um):
> >>
> >> CC drivers/base/platform.o
> >> In file included from ./arch/x86/um/asm/processor.h:31:0,
> >> from ./arch/um/include/asm/uaccess.h:16,
> >> from ./arch/um/include/asm/thread_info.h:13,
> >> from include/linux/thread_info.h:54,
> >> from include/asm-generic/current.h:4,
> >> from arch/um/include/generated/asm/current.h:1,
> >> from include/linux/mutex.h:13,
> >> from include/linux/kernfs.h:13,
> >> from include/linux/sysfs.h:15,
> >> from include/linux/kobject.h:21,
> >> from include/linux/device.h:17,
> >> from include/linux/platform_device.h:14,
> >> from drivers/base/platform.c:14:
> >> ./arch/um/include/asm/processor-generic.h:107:19: error: expected identifier or '(' before '&' token
> >> #define cpu_data (&boot_cpu_data)
> >> ^
> >> include/linux/pm_domain.h:74:23: note: in expansion of macro 'cpu_data'
> >> struct gpd_cpu_data *cpu_data;
> >> ^
> >>
> >> Also need notice about 80 columns boundary.
> >
> > I don't object to this change at all, but it could be easier to solve
> > this by fixing up 'cpu_data' to be named something a bit less "generic"?
> > What does x86 use for this data type?
> >
>
> It is for some kinds of arm cpu (I let this patch pass arm s3c600
> def_config building). Other architectures did not use it, at present.
So why not change the name for these archs that have such a generic name
to something not so generic?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] drivers: base: power: domain: Use 'pm_cpu_data' instead of 'cpu_data' for compiling break
2014-10-05 1:23 ` Greg KH
@ 2014-10-05 2:11 ` Chen Gang
0 siblings, 0 replies; 11+ messages in thread
From: Chen Gang @ 2014-10-05 2:11 UTC (permalink / raw)
To: Greg KH
Cc: rjw, pavel, len.brown, ulf.hansson, khilman, geert+renesas,
tomasz.figa, richard, linux-pm, linux-kernel
On 10/5/14 9:23, Greg KH wrote:
> On Sun, Oct 05, 2014 at 09:13:09AM +0800, Chen Gang wrote:
>> On 10/5/14 0:00, Greg KH wrote:
>>> On Sat, Oct 04, 2014 at 10:19:50PM +0800, Chen Gang wrote:
>>>> 'cpu_data' is too common to be already used by some architectures (e.g.
>>>> um, m32r, and mn10300), so need use 'pm_cpu_data' instead of, or cause
>>>> compiling break. The related error (with allmodconfig under um):
>>>>
>>>> CC drivers/base/platform.o
>>>> In file included from ./arch/x86/um/asm/processor.h:31:0,
>>>> from ./arch/um/include/asm/uaccess.h:16,
>>>> from ./arch/um/include/asm/thread_info.h:13,
>>>> from include/linux/thread_info.h:54,
>>>> from include/asm-generic/current.h:4,
>>>> from arch/um/include/generated/asm/current.h:1,
>>>> from include/linux/mutex.h:13,
>>>> from include/linux/kernfs.h:13,
>>>> from include/linux/sysfs.h:15,
>>>> from include/linux/kobject.h:21,
>>>> from include/linux/device.h:17,
>>>> from include/linux/platform_device.h:14,
>>>> from drivers/base/platform.c:14:
>>>> ./arch/um/include/asm/processor-generic.h:107:19: error: expected identifier or '(' before '&' token
>>>> #define cpu_data (&boot_cpu_data)
>>>> ^
>>>> include/linux/pm_domain.h:74:23: note: in expansion of macro 'cpu_data'
>>>> struct gpd_cpu_data *cpu_data;
>>>> ^
>>>>
>>>> Also need notice about 80 columns boundary.
>>>
>>> I don't object to this change at all, but it could be easier to solve
>>> this by fixing up 'cpu_data' to be named something a bit less "generic"?
>>> What does x86 use for this data type?
>>>
>>
>> It is for some kinds of arm cpu (I let this patch pass arm s3c600
>> def_config building). Other architectures did not use it, at present.
>
> So why not change the name for these archs that have such a generic name
> to something not so generic?
>
All the code are really generic, I don't know whether it will be used
under other architectures in the future (I guess, it will, or it need
not be put to "drivers/base/power/" and "include/linux").
At present, it is not used by other architectures, but it already has
negative effect with other architectures (I found it during compiling
um architecture).
So for me, this issue is not only within arm itself, but also in common
drivers.
Thanks
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drivers: base: power: domain: Use 'pm_cpu_data' instead of 'cpu_data' for compiling break
2014-10-05 1:13 ` Chen Gang
2014-10-05 1:23 ` Greg KH
@ 2014-10-05 1:31 ` Chen Gang
1 sibling, 0 replies; 11+ messages in thread
From: Chen Gang @ 2014-10-05 1:31 UTC (permalink / raw)
To: Greg KH
Cc: rjw, pavel, len.brown, ulf.hansson, khilman, geert+renesas,
tomasz.figa, richard, linux-pm, linux-kernel
On 10/5/14 9:13, Chen Gang wrote:
> On 10/5/14 0:00, Greg KH wrote:
>> On Sat, Oct 04, 2014 at 10:19:50PM +0800, Chen Gang wrote:
>>> 'cpu_data' is too common to be already used by some architectures (e.g.
>>> um, m32r, and mn10300), so need use 'pm_cpu_data' instead of, or cause
>>> compiling break. The related error (with allmodconfig under um):
>>>
>>> CC drivers/base/platform.o
>>> In file included from ./arch/x86/um/asm/processor.h:31:0,
>>> from ./arch/um/include/asm/uaccess.h:16,
>>> from ./arch/um/include/asm/thread_info.h:13,
>>> from include/linux/thread_info.h:54,
>>> from include/asm-generic/current.h:4,
>>> from arch/um/include/generated/asm/current.h:1,
>>> from include/linux/mutex.h:13,
>>> from include/linux/kernfs.h:13,
>>> from include/linux/sysfs.h:15,
>>> from include/linux/kobject.h:21,
>>> from include/linux/device.h:17,
>>> from include/linux/platform_device.h:14,
>>> from drivers/base/platform.c:14:
>>> ./arch/um/include/asm/processor-generic.h:107:19: error: expected identifier or '(' before '&' token
>>> #define cpu_data (&boot_cpu_data)
>>> ^
>>> include/linux/pm_domain.h:74:23: note: in expansion of macro 'cpu_data'
>>> struct gpd_cpu_data *cpu_data;
>>> ^
>>>
>>> Also need notice about 80 columns boundary.
>>
>> I don't object to this change at all, but it could be easier to solve
>> this by fixing up 'cpu_data' to be named something a bit less "generic"?
>> What does x86 use for this data type?
>>
>
> It is for some kinds of arm cpu (I let this patch pass arm s3c600
Oh, sorry, typo issue, it is s3c6400 def_config.
> def_config building). Other architectures did not use it, at present.
>
> If necessary to complete the comments, please let me know, I shall send
> patch v2 for it.
>
> Thanks.
>
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drivers: base: power: domain: Use 'pm_cpu_data' instead of 'cpu_data' for compiling break
2014-10-04 16:00 ` Greg KH
2014-10-05 1:13 ` Chen Gang
@ 2014-10-05 2:42 ` Randy Dunlap
2014-10-05 2:57 ` Chen Gang
1 sibling, 1 reply; 11+ messages in thread
From: Randy Dunlap @ 2014-10-05 2:42 UTC (permalink / raw)
To: Greg KH, Chen Gang
Cc: rjw, pavel, len.brown, ulf.hansson, khilman, geert+renesas,
tomasz.figa, richard, linux-pm, linux-kernel
On 10/04/14 09:00, Greg KH wrote:
> On Sat, Oct 04, 2014 at 10:19:50PM +0800, Chen Gang wrote:
>> 'cpu_data' is too common to be already used by some architectures (e.g.
>> um, m32r, and mn10300), so need use 'pm_cpu_data' instead of, or cause
>> compiling break. The related error (with allmodconfig under um):
>>
>> CC drivers/base/platform.o
>> In file included from ./arch/x86/um/asm/processor.h:31:0,
>> from ./arch/um/include/asm/uaccess.h:16,
>> from ./arch/um/include/asm/thread_info.h:13,
>> from include/linux/thread_info.h:54,
>> from include/asm-generic/current.h:4,
>> from arch/um/include/generated/asm/current.h:1,
>> from include/linux/mutex.h:13,
>> from include/linux/kernfs.h:13,
>> from include/linux/sysfs.h:15,
>> from include/linux/kobject.h:21,
>> from include/linux/device.h:17,
>> from include/linux/platform_device.h:14,
>> from drivers/base/platform.c:14:
>> ./arch/um/include/asm/processor-generic.h:107:19: error: expected identifier or '(' before '&' token
>> #define cpu_data (&boot_cpu_data)
>> ^
>> include/linux/pm_domain.h:74:23: note: in expansion of macro 'cpu_data'
>> struct gpd_cpu_data *cpu_data;
>> ^
>>
>> Also need notice about 80 columns boundary.
>
> I don't object to this change at all, but it could be easier to solve
> this by fixing up 'cpu_data' to be named something a bit less "generic"?
> What does x86 use for this data type?
The patch makes sense to me.
These arch-es already have 'cpu_data' in some form:
mips, sparc, arm64, blackfin, frv, mn10300, parisc, um(l), c6x, x86, xtensa,
alpha, m32r, arm, ia64, metag, sn.
--
~Randy
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] drivers: base: power: domain: Use 'pm_cpu_data' instead of 'cpu_data' for compiling break
2014-10-05 2:42 ` Randy Dunlap
@ 2014-10-05 2:57 ` Chen Gang
0 siblings, 0 replies; 11+ messages in thread
From: Chen Gang @ 2014-10-05 2:57 UTC (permalink / raw)
To: Randy Dunlap, Greg KH
Cc: rjw, pavel, len.brown, ulf.hansson, khilman, geert+renesas,
tomasz.figa, richard, linux-pm, linux-kernel
On 10/5/14 10:42, Randy Dunlap wrote:
> On 10/04/14 09:00, Greg KH wrote:
>> On Sat, Oct 04, 2014 at 10:19:50PM +0800, Chen Gang wrote:
>>> 'cpu_data' is too common to be already used by some architectures (e.g.
>>> um, m32r, and mn10300), so need use 'pm_cpu_data' instead of, or cause
>>> compiling break. The related error (with allmodconfig under um):
>>>
>>> CC drivers/base/platform.o
>>> In file included from ./arch/x86/um/asm/processor.h:31:0,
>>> from ./arch/um/include/asm/uaccess.h:16,
>>> from ./arch/um/include/asm/thread_info.h:13,
>>> from include/linux/thread_info.h:54,
>>> from include/asm-generic/current.h:4,
>>> from arch/um/include/generated/asm/current.h:1,
>>> from include/linux/mutex.h:13,
>>> from include/linux/kernfs.h:13,
>>> from include/linux/sysfs.h:15,
>>> from include/linux/kobject.h:21,
>>> from include/linux/device.h:17,
>>> from include/linux/platform_device.h:14,
>>> from drivers/base/platform.c:14:
>>> ./arch/um/include/asm/processor-generic.h:107:19: error: expected identifier or '(' before '&' token
>>> #define cpu_data (&boot_cpu_data)
>>> ^
>>> include/linux/pm_domain.h:74:23: note: in expansion of macro 'cpu_data'
>>> struct gpd_cpu_data *cpu_data;
>>> ^
>>>
>>> Also need notice about 80 columns boundary.
>>
>> I don't object to this change at all, but it could be easier to solve
>> this by fixing up 'cpu_data' to be named something a bit less "generic"?
>> What does x86 use for this data type?
>
> The patch makes sense to me.
>
> These arch-es already have 'cpu_data' in some form:
>
> mips, sparc, arm64, blackfin, frv, mn10300, parisc, um(l), c6x, x86, xtensa,
> alpha, m32r, arm, ia64, metag, sn.
>
Yeah, and m32r, mn10300 and um may let cpu_data as macro variable, which
may cause this issue. And others let cpu_data as function (or like a
function), I guess, they may not cause this issue.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drivers: base: power: domain: Use 'pm_cpu_data' instead of 'cpu_data' for compiling break
2014-10-04 14:19 [PATCH] drivers: base: power: domain: Use 'pm_cpu_data' instead of 'cpu_data' for compiling break Chen Gang
2014-10-04 14:20 ` Chen Gang
2014-10-04 16:00 ` Greg KH
@ 2014-10-05 21:32 ` Rafael J. Wysocki
2014-10-05 23:55 ` Chen Gang
2 siblings, 1 reply; 11+ messages in thread
From: Rafael J. Wysocki @ 2014-10-05 21:32 UTC (permalink / raw)
To: Chen Gang
Cc: pavel, len.brown, gregkh, ulf.hansson, khilman, geert+renesas,
tomasz.figa, richard, linux-pm, linux-kernel, Randy Dunlap
On Saturday, October 04, 2014 10:19:50 PM Chen Gang wrote:
> 'cpu_data' is too common to be already used by some architectures (e.g.
> um, m32r, and mn10300), so need use 'pm_cpu_data' instead of, or cause
> compiling break. The related error (with allmodconfig under um):
>
> CC drivers/base/platform.o
> In file included from ./arch/x86/um/asm/processor.h:31:0,
> from ./arch/um/include/asm/uaccess.h:16,
> from ./arch/um/include/asm/thread_info.h:13,
> from include/linux/thread_info.h:54,
> from include/asm-generic/current.h:4,
> from arch/um/include/generated/asm/current.h:1,
> from include/linux/mutex.h:13,
> from include/linux/kernfs.h:13,
> from include/linux/sysfs.h:15,
> from include/linux/kobject.h:21,
> from include/linux/device.h:17,
> from include/linux/platform_device.h:14,
> from drivers/base/platform.c:14:
> ./arch/um/include/asm/processor-generic.h:107:19: error: expected identifier or '(' before '&' token
> #define cpu_data (&boot_cpu_data)
> ^
> include/linux/pm_domain.h:74:23: note: in expansion of macro 'cpu_data'
> struct gpd_cpu_data *cpu_data;
> ^
>
> Also need notice about 80 columns boundary.
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
This problem has already been fixed by a patch from Ulf Hansson that's
in my tree (along with the commit that introduced the problem in the first
place).
And you forgot to say that the problem was only occuring in linux-next.
I'm sorry for everyone's loss of time related to this.
> ---
> drivers/base/power/domain.c | 54 ++++++++++++++++++++++-----------------------
> include/linux/pm_domain.h | 2 +-
> 2 files changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 18cc68d..d8d2739 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -142,13 +142,13 @@ static void genpd_recalc_cpu_exit_latency(struct generic_pm_domain *genpd)
> {
> s64 usecs64;
>
> - if (!genpd->cpu_data)
> + if (!genpd->pm_cpu_data)
> return;
>
> usecs64 = genpd->power_on_latency_ns;
> do_div(usecs64, NSEC_PER_USEC);
> - usecs64 += genpd->cpu_data->saved_exit_latency;
> - genpd->cpu_data->idle_state->exit_latency = usecs64;
> + usecs64 += genpd->pm_cpu_data->saved_exit_latency;
> + genpd->pm_cpu_data->idle_state->exit_latency = usecs64;
> }
>
> /**
> @@ -188,9 +188,9 @@ static int __pm_genpd_poweron(struct generic_pm_domain *genpd)
> return 0;
> }
>
> - if (genpd->cpu_data) {
> + if (genpd->pm_cpu_data) {
> cpuidle_pause_and_lock();
> - genpd->cpu_data->idle_state->disabled = true;
> + genpd->pm_cpu_data->idle_state->disabled = true;
> cpuidle_resume_and_unlock();
> goto out;
> }
> @@ -513,17 +513,17 @@ static int pm_genpd_poweroff(struct generic_pm_domain *genpd)
> }
> }
>
> - if (genpd->cpu_data) {
> + if (genpd->pm_cpu_data) {
> /*
> - * If cpu_data is set, cpuidle should turn the domain off when
> - * the CPU in it is idle. In that case we don't decrement the
> - * subdomain counts of the master domains, so that power is not
> - * removed from the current domain prematurely as a result of
> - * cutting off the masters' power.
> + * If pm_cpu_data is set, cpuidle should turn the domain off
> + * when the CPU in it is idle. In that case we don't decrement
> + * the subdomain counts of the master domains, so that power is
> + * not removed from the current domain prematurely as a result
> + * of cutting off the masters' power.
> */
> genpd->status = GPD_STATE_POWER_OFF;
> cpuidle_pause_and_lock();
> - genpd->cpu_data->idle_state->disabled = false;
> + genpd->pm_cpu_data->idle_state->disabled = false;
> cpuidle_resume_and_unlock();
> goto out;
> }
> @@ -1698,7 +1698,7 @@ int pm_genpd_remove_subdomain(struct generic_pm_domain *genpd,
> int pm_genpd_attach_cpuidle(struct generic_pm_domain *genpd, int state)
> {
> struct cpuidle_driver *cpuidle_drv;
> - struct gpd_cpu_data *cpu_data;
> + struct gpd_cpu_data *pm_cpu_data;
> struct cpuidle_state *idle_state;
> int ret = 0;
>
> @@ -1707,12 +1707,12 @@ int pm_genpd_attach_cpuidle(struct generic_pm_domain *genpd, int state)
>
> genpd_acquire_lock(genpd);
>
> - if (genpd->cpu_data) {
> + if (genpd->pm_cpu_data) {
> ret = -EEXIST;
> goto out;
> }
> - cpu_data = kzalloc(sizeof(*cpu_data), GFP_KERNEL);
> - if (!cpu_data) {
> + pm_cpu_data = kzalloc(sizeof(*pm_cpu_data), GFP_KERNEL);
> + if (!pm_cpu_data) {
> ret = -ENOMEM;
> goto out;
> }
> @@ -1730,9 +1730,9 @@ int pm_genpd_attach_cpuidle(struct generic_pm_domain *genpd, int state)
> ret = -EAGAIN;
> goto err;
> }
> - cpu_data->idle_state = idle_state;
> - cpu_data->saved_exit_latency = idle_state->exit_latency;
> - genpd->cpu_data = cpu_data;
> + pm_cpu_data->idle_state = idle_state;
> + pm_cpu_data->saved_exit_latency = idle_state->exit_latency;
> + genpd->pm_cpu_data = pm_cpu_data;
> genpd_recalc_cpu_exit_latency(genpd);
>
> out:
> @@ -1743,7 +1743,7 @@ int pm_genpd_attach_cpuidle(struct generic_pm_domain *genpd, int state)
> cpuidle_driver_unref();
>
> err_drv:
> - kfree(cpu_data);
> + kfree(pm_cpu_data);
> goto out;
> }
>
> @@ -1766,7 +1766,7 @@ int pm_genpd_name_attach_cpuidle(const char *name, int state)
> */
> int pm_genpd_detach_cpuidle(struct generic_pm_domain *genpd)
> {
> - struct gpd_cpu_data *cpu_data;
> + struct gpd_cpu_data *pm_cpu_data;
> struct cpuidle_state *idle_state;
> int ret = 0;
>
> @@ -1775,20 +1775,20 @@ int pm_genpd_detach_cpuidle(struct generic_pm_domain *genpd)
>
> genpd_acquire_lock(genpd);
>
> - cpu_data = genpd->cpu_data;
> - if (!cpu_data) {
> + pm_cpu_data = genpd->pm_cpu_data;
> + if (!pm_cpu_data) {
> ret = -ENODEV;
> goto out;
> }
> - idle_state = cpu_data->idle_state;
> + idle_state = pm_cpu_data->idle_state;
> if (!idle_state->disabled) {
> ret = -EAGAIN;
> goto out;
> }
> - idle_state->exit_latency = cpu_data->saved_exit_latency;
> + idle_state->exit_latency = pm_cpu_data->saved_exit_latency;
> cpuidle_driver_unref();
> - genpd->cpu_data = NULL;
> - kfree(cpu_data);
> + genpd->pm_cpu_data = NULL;
> + kfree(pm_cpu_data);
>
> out:
> genpd_release_lock(genpd);
> diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
> index 9004743..a73b825 100644
> --- a/include/linux/pm_domain.h
> +++ b/include/linux/pm_domain.h
> @@ -71,7 +71,7 @@ struct generic_pm_domain {
> s64 max_off_time_ns; /* Maximum allowed "suspended" time. */
> bool max_off_time_changed;
> bool cached_power_down_ok;
> - struct gpd_cpu_data *cpu_data;
> + struct gpd_cpu_data *pm_cpu_data;
> void (*attach_dev)(struct device *dev);
> void (*detach_dev)(struct device *dev);
> };
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] drivers: base: power: domain: Use 'pm_cpu_data' instead of 'cpu_data' for compiling break
2014-10-05 21:32 ` Rafael J. Wysocki
@ 2014-10-05 23:55 ` Chen Gang
0 siblings, 0 replies; 11+ messages in thread
From: Chen Gang @ 2014-10-05 23:55 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: pavel, len.brown, gregkh, ulf.hansson, khilman, geert+renesas,
tomasz.figa, richard, linux-pm, linux-kernel, Randy Dunlap
On 10/6/14 5:32, Rafael J. Wysocki wrote:
> On Saturday, October 04, 2014 10:19:50 PM Chen Gang wrote:
>> 'cpu_data' is too common to be already used by some architectures (e.g.
>> um, m32r, and mn10300), so need use 'pm_cpu_data' instead of, or cause
>> compiling break. The related error (with allmodconfig under um):
>>
>> CC drivers/base/platform.o
>> In file included from ./arch/x86/um/asm/processor.h:31:0,
>> from ./arch/um/include/asm/uaccess.h:16,
>> from ./arch/um/include/asm/thread_info.h:13,
>> from include/linux/thread_info.h:54,
>> from include/asm-generic/current.h:4,
>> from arch/um/include/generated/asm/current.h:1,
>> from include/linux/mutex.h:13,
>> from include/linux/kernfs.h:13,
>> from include/linux/sysfs.h:15,
>> from include/linux/kobject.h:21,
>> from include/linux/device.h:17,
>> from include/linux/platform_device.h:14,
>> from drivers/base/platform.c:14:
>> ./arch/um/include/asm/processor-generic.h:107:19: error: expected identifier or '(' before '&' token
>> #define cpu_data (&boot_cpu_data)
>> ^
>> include/linux/pm_domain.h:74:23: note: in expansion of macro 'cpu_data'
>> struct gpd_cpu_data *cpu_data;
>> ^
>>
>> Also need notice about 80 columns boundary.
>>
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>
> This problem has already been fixed by a patch from Ulf Hansson that's
> in my tree (along with the commit that introduced the problem in the first
> place).
>
OK, thanks, that is good news to us all.
> And you forgot to say that the problem was only occuring in linux-next.
>
OK, thanks, next, I shall mark 'next' in subject, e.g. [PATH next] ...
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 11+ messages in thread