linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Shawn Guo <shawn.guo@freescale.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Fabio Estevam <festevam@gmail.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: cpufreq: Unable to set cpufreq to maximum
Date: Mon, 06 Oct 2014 12:05:57 +0200	[thread overview]
Message-ID: <54326985.2030207@i2se.com> (raw)
In-Reply-To: <CAKohpokbWGu9KBixMTCUbv9RobfYmpZjNDdYEJ78V-5b9D7_Wg@mail.gmail.com>

Am 06.10.2014 um 11:26 schrieb Viresh Kumar:
> On 6 October 2014 14:43, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>> Sorry, about the confusion. The main problem about setting cpufreq to
>> maximum has been fixed by DT settings. Above i talked about an idea to
>> fix the confusing warning after fixing the main problem:
>>
>> root@duckbill:~# modprobe cpufreq-cpu0
>> [   48.573808] cpufreq: __cpufreq_add_dev: CPU0: Running at unlisted
>> freq: 454736 KHz
>> [   48.604871] cpufreq: __cpufreq_add_dev: CPU0: Unlisted initial
>> frequency changed to: 454737 KHz
>>
>> But the best solution would be a more intelligent function like
>> dev_pm_opp_find_freq_nearest() which find the OPP with the smallest
>> frequency distance. So nobody of the DTS users has to care about
>> frequency rounding.
>>
>> Currently i'm trying to adapt the DTS file to the driver and that's not
>> the intention of devicetree.
> It looks that one of us hasn't understood how things are working :)

I think i know him ;-)

>
>  So here is my part of theory:
> - Search for CPUFREQ_NEED_INITIAL_FREQ_CHECK in cpufreq.c
> - When starting cpufreq core for every CPU we check if the current
> frequency at which is running is mentioned in DT. If not, we throw above
> warnings and fix the freq.

Okay i.MX28 cpu is running initial on 454736842 Hz. 454736 kHz in the DT
will make cpufreq core happy, but cpufreq-cpu0 will select next lower
frequency. 454737 kHz in the DT will make cpufreq sad, but it's
selectable by cpufreq-cpu0.

Is it possible cpufreq core round the clock frequency down?

> - Until this time cpufreq-driver's ->target_index() routine hasn't come
> into picture and so NO opp routine will fix that..
>
> Does this sound reasonable ?

Thanks for your explanation.

Stefan

  reply	other threads:[~2014-10-06 10:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 13:17 cpufreq: Unable to set cpufreq to maximum Stefan Wahren
2014-10-02 13:59 ` Lucas Stach
2014-10-02 15:01   ` Stefan Wahren
2014-10-02 15:22     ` Lucas Stach
2014-10-02 16:10       ` Stefan Wahren
2014-10-06  4:21       ` Viresh Kumar
2014-10-06  6:41         ` Stefan Wahren
2014-10-06  8:50           ` Viresh Kumar
2014-10-06  9:13             ` Stefan Wahren
2014-10-06  9:26               ` Viresh Kumar
2014-10-06 10:05                 ` Stefan Wahren [this message]
2014-10-06 10:16                   ` Viresh Kumar
2014-10-06 11:12                     ` Stefan Wahren
2014-10-06 11:18                       ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54326985.2030207@i2se.com \
    --to=stefan.wahren@i2se.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=l.stach@pengutronix.de \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=shawn.guo@freescale.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).