From: Prarit Bhargava <prarit@redhat.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Robert Schöne" <robert.schoene@tu-dresden.de>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Lists linaro-kernel" <linaro-kernel@lists.linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Saravana Kannan" <skannan@codeaurora.org>
Subject: Re: [PATCH 1/2] cpufreq: serialize calls to __cpufreq_governor()
Date: Fri, 17 Oct 2014 08:12:44 -0400 [thread overview]
Message-ID: <544107BC.3090002@redhat.com> (raw)
In-Reply-To: <CAKohpom6Eii=4OUe-gn8vJMRD56kxKN2iobqoKkqHLa2eYah3Q@mail.gmail.com>
On 10/16/2014 06:58 AM, Viresh Kumar wrote:
> On 14 October 2014 22:42, Prarit Bhargava <prarit@redhat.com> wrote:
>> I spoke too soon :( On a larger system (128 processors, 64 cores, two threads
>> each)) the system locks up in about 1 minute using Robert's test. The
>
> :(
>
>> [ 2484.634827] NMI watchdog: BUG: soft lockup - CPU#31 stuck for 22s! [tee:34538]^M
>> [ 2484.634827] Modules linked in: sg nfsv3 rpcsec_gss_krb5 nfsv4 dns_resolver
>> nfs fscache cfg80211 rfkill x86_pkg_temp_thermal intel_powerclamp coretemp
>> kvm_intel kvm crct10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel
>> aesni_intel lrw igb gf128mul iTCO_wdt ioatdma ptp glue_helper sb_edac
>> iTCO_vendor_support ablk_helper pps_core lpc_ich edac_core dca cryptd mfd_core
>> shpchp pcspkr i2c_i801 ipmi_si ipmi_msghandler wmi nfsd acpi_cpufreq auth_rpcgss
>> nfs_acl lockd grace sunrpc xfs libcrc32c sd_mod sr_mod cdrom crc_t10dif
>> crct10dif_common mgag200 syscopyarea sysfillrect sysimgblt i2c_algo_bit
>> drm_kms_helper ttm isci drm libsas ahci libahci scsi_transport_sas libata
>> i2c_core dm_mirror dm_region_hash dm_log dm_mod^M
>>
>> [ 2484.634850] CPU: 31 PID: 34538 Comm: tee Tainted: G L 3.17.0+ #10^M
>> [ 2484.634851] Hardware name: Intel Corporation S2600CP/S2600CP, BIOS
>> RMLSDP.86I.00.29.D696.1311111329 11/11/2013^M
>> [ 2484.634851] task: ffff881010376c80 ti: ffff880804938000 task.ti:
>> ffff880804938000^M
>> [ 2484.634852] RIP: 0010:[<ffffffff814e65dc>] [<ffffffff814e65dc>]
>> __cpufreq_governor+0x6c/0x2c0^M
>> [ 2484.634855] RSP: 0018:ffff88080493bc68 EFLAGS: 00000246^M
>> [ 2484.634856] RAX: 0000000000000001 RBX: ffffffff8165a622 RCX: 0000000000262988^M
>> [ 2484.634857] RDX: 0000000000000000 RSI: ffffffff81a72960 RDI: ffff88100db9b400^M
>> [ 2484.634857] RBP: ffff88080493bc90 R08: 0000000000000000 R09: 0000000000124f80^M
>> [ 2484.634858] R10: 0000000000262988 R11: 0000000000000246 R12: ffff88080493bcd8^M
>> [ 2484.634858] R13: ffffffff813a0c22 R14: ffff88080493bbe0 R15: ffff88080490f518^M
>> [ 2484.634859] FS: 00007f8045e7f740(0000) GS:ffff88081f060000(0000)
>> knlGS:0000000000000000^M
>> [ 2484.634860] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033^M
>> [ 2484.634860] CR2: 000000000080b108 CR3: 000000080e86f000 CR4: 00000000001407e0^M
>> [ 2484.634861] Stack:^M
>> [ 2484.634861] ffff88080493bcd8 ffff88100db9b400 0000000000000000
>> ffffffff81a72960^M
>> [ 2484.634862] ffff88100db9b400 ffff88080493bcc8 ffffffff814e6a33
>> ffff88100db9b400^M
>> [ 2484.634863] ffff88080d0c5430 0000000000000009 0000000000000009
>> ffff88100db9b400^M
>> [ 2484.634865] Call Trace:^M
>> [ 2484.634865] [<ffffffff814e6a33>] cpufreq_set_policy+0x203/0x310^M
>> [ 2484.634867] [<ffffffff814e6e1d>] store_scaling_governor+0xad/0xf0^M
>> [ 2484.634869] [<ffffffff814e6d30>] ? cpufreq_update_policy+0x1f0/0x1f0^M
>> [ 2484.634872] [<ffffffff810b5500>] ? add_wait_queue_exclusive+0x20/0x50^M
>> [ 2484.634873] [<ffffffff814e5899>] store+0x79/0xc0^M
>> [ 2484.634875] [<ffffffff8126197d>] sysfs_kf_write+0x3d/0x50^M
>> [ 2484.634876] [<ffffffff81260ec0>] kernfs_fop_write+0xe0/0x160^M
>> [ 2484.634878] [<ffffffff811e9a67>] vfs_write+0xb7/0x1f0^M
>> [ 2484.634879] [<ffffffff811ea685>] SyS_write+0x55/0xd0^M
>> [ 2484.634881] [<ffffffff8165c8e9>] system_call_fastpath+0x16/0x1b^M
>> [ 2484.634883] Code: 05 3b 87 5c 00 04 0f 85 50 02 00 00 0f 1f 00 48 8b 05 71 35
>> a2 00 0f b6 50 10 83 e2 08 eb 08 0f b6 43 64 84 c0 74 10 84 d2 75 f4 <48> 8b 43
>> 50 0f b6 40 50 84 c0 75 f0 48 c7 c7 60 27 a7 81 e8 1c ^M
>
> Not sure what's going on here.. Better would be if you can decode things like
> this while reporting bugs:
>
> __cpufreq_governor+0x6c/0x2c0
>
/home/linux/drivers/cpufreq/cpufreq.c: 119
0xffffffff814e65dc <__cpufreq_governor+0x6c>: mov 0x50(%rbx),%rax
0xffffffff814e65e0 <__cpufreq_governor+0x70>: movzbl 0x50(%rax),%eax
bool is_governor_busy(struct cpufreq_policy *policy)
{
if (have_governor_per_policy())
return policy->governor_busy;
else
return policy->governor->governor_busy; <<< this line?
}
> So that we know what part of code screwed it up..
>
next prev parent reply other threads:[~2014-10-17 12:12 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 7:04 [PATCH 1/2] cpufreq: serialize calls to __cpufreq_governor() Viresh Kumar
2014-10-08 12:46 ` Prarit Bhargava
2014-10-10 9:04 ` Viresh Kumar
2014-10-10 10:41 ` Robert Schöne
2014-10-10 11:14 ` Viresh Kumar
2014-10-10 11:21 ` Prarit Bhargava
2014-10-10 11:30 ` Viresh Kumar
2014-10-10 11:38 ` Prarit Bhargava
2014-10-10 11:46 ` Viresh Kumar
2014-10-10 11:48 ` Prarit Bhargava
2014-10-10 12:01 ` Robert Schöne
2014-10-10 12:39 ` Viresh Kumar
2014-10-10 13:04 ` Robert Schöne
2014-10-10 13:23 ` Robert Schöne
2014-10-10 13:52 ` Viresh Kumar
2014-10-10 14:05 ` Robert Schöne
2014-10-14 6:58 ` Viresh Kumar
2014-10-14 11:42 ` Prarit Bhargava
2014-10-14 17:12 ` Prarit Bhargava
2014-10-16 10:58 ` Viresh Kumar
2014-10-17 12:12 ` Prarit Bhargava [this message]
2014-10-16 10:57 ` Viresh Kumar
2014-10-17 12:09 ` Prarit Bhargava
-- strict thread matches above, loose matches on Subject: below --
2014-10-10 13:55 Prarit Bhargava
2014-10-10 13:58 ` Viresh Kumar
2014-10-10 13:40 Prarit Bhargava
2014-10-10 13:42 ` Robert Schöne
2014-09-09 4:16 Viresh Kumar
2014-09-09 7:29 ` Robert Schöne
2014-09-09 7:35 ` Viresh Kumar
[not found] ` <540EEA95.8030208@redhat.com>
2014-09-09 14:45 ` Viresh Kumar
2014-09-24 23:46 ` Rafael J. Wysocki
2014-09-25 6:07 ` Robert Schöne
2014-09-29 9:50 ` Viresh Kumar
2014-09-29 11:29 ` Prarit Bhargava
2014-09-29 11:38 ` Viresh Kumar
2014-09-29 11:50 ` Prarit Bhargava
2014-09-29 11:55 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544107BC.3090002@redhat.com \
--to=prarit@redhat.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robert.schoene@tu-dresden.de \
--cc=skannan@codeaurora.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).