From: Dirk Brandewie <dirk.brandewie@gmail.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
James Geboski <jgeboski@gmail.com>
Cc: dirk.j.brandewie@intel.com,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
'Dirk Brandewie' <dirk.brandewie@gmail.com>
Subject: Re: [PATCH v2] cpufreq: allow powersave governor as the default without expert mode
Date: Thu, 30 Oct 2014 23:15:09 -0700 [thread overview]
Message-ID: <545328ED.20900@intel.com> (raw)
In-Reply-To: <1463060.7rHn3OIKry@vostro.rjw.lan>
On 10/30/2014 02:18 PM, Rafael J. Wysocki wrote:
> On Thursday, October 16, 2014 07:37:11 AM James Geboski wrote:
>> The intel_pstate driver only supports the performance and the powersave
>> governors. With the performance governor ensuring the highest possible
>> performance settings, userspace tools fail to make any lasting changes.
>> In order to allow userspace tools to make modifications to the settings,
>> the powersave governor must be in use. This makes having the powersave
>> governor as the default convenient for systems where the intel_pstate
>> driver is being employed. Having to enable expert mode in the kernel
>> configuration is just a headache for such a trivial task.
>>
>> This patch applies to all kernel versions 2.6.38 or greater after the
>> migration from CONFIG_EMBEDDED to CONFIG_EXPERT (6a108a14fa35). Most
>> importantly, this applies to kernel versions 3.9 or greater when the
>> intel_pstate driver was introduced.
>>
>> Signed-off-by: James Geboski <jgeboski@gmail.com>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Dirk, any objections?
No objection.
>
>> ---
>> ChangeLog v2:
>> - Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>> ---
>> drivers/cpufreq/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
>> index 3489f8f..73df7db 100644
>> --- a/drivers/cpufreq/Kconfig
>> +++ b/drivers/cpufreq/Kconfig
>> @@ -63,7 +63,6 @@ config CPU_FREQ_DEFAULT_GOV_PERFORMANCE
>>
>> config CPU_FREQ_DEFAULT_GOV_POWERSAVE
>> bool "powersave"
>> - depends on EXPERT
>> select CPU_FREQ_GOV_POWERSAVE
>> help
>> Use the CPUFreq governor 'powersave' as default. This sets
>>
>
next prev parent reply other threads:[~2014-10-31 6:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 21:38 [PATCH] cpufreq: allow powersave governor as the default without expert mode James Geboski
2014-10-16 8:15 ` Viresh Kumar
2014-10-16 11:37 ` [PATCH v2] " James Geboski
2014-10-30 21:18 ` Rafael J. Wysocki
2014-10-31 6:15 ` Dirk Brandewie [this message]
2014-11-08 1:38 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545328ED.20900@intel.com \
--to=dirk.brandewie@gmail.com \
--cc=dirk.j.brandewie@intel.com \
--cc=jgeboski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).