* [PATCH] cpufreq: allow powersave governor as the default without expert mode
@ 2014-10-14 21:38 James Geboski
2014-10-16 8:15 ` Viresh Kumar
2014-10-16 11:37 ` [PATCH v2] " James Geboski
0 siblings, 2 replies; 6+ messages in thread
From: James Geboski @ 2014-10-14 21:38 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar; +Cc: linux-pm, linux-kernel, James Geboski
The intel_pstate driver only supports the performance and the powersave
governors. With the performance governor ensuring the highest possible
performance settings, userspace tools fail to make any lasting changes.
In order to allow userspace tools to make modifications to the settings,
the powersave governor must be in use. This makes having the powersave
governor as the default convenient for systems where the intel_pstate
driver is being employed. Having to enable expert mode in the kernel
configuration is just a headache for such a trivial task.
This patch applies to all kernel versions 2.6.38 or greater after the
migration from CONFIG_EMBEDDED to CONFIG_EXPERT (6a108a14fa35). Most
importantly, this applies to kernel versions 3.9 or greater when the
intel_pstate driver was introduced.
Signed-off-by: James Geboski <jgeboski@gmail.com>
---
drivers/cpufreq/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
index 3489f8f..73df7db 100644
--- a/drivers/cpufreq/Kconfig
+++ b/drivers/cpufreq/Kconfig
@@ -63,7 +63,6 @@ config CPU_FREQ_DEFAULT_GOV_PERFORMANCE
config CPU_FREQ_DEFAULT_GOV_POWERSAVE
bool "powersave"
- depends on EXPERT
select CPU_FREQ_GOV_POWERSAVE
help
Use the CPUFreq governor 'powersave' as default. This sets
--
2.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] cpufreq: allow powersave governor as the default without expert mode
2014-10-14 21:38 [PATCH] cpufreq: allow powersave governor as the default without expert mode James Geboski
@ 2014-10-16 8:15 ` Viresh Kumar
2014-10-16 11:37 ` [PATCH v2] " James Geboski
1 sibling, 0 replies; 6+ messages in thread
From: Viresh Kumar @ 2014-10-16 8:15 UTC (permalink / raw)
To: James Geboski
Cc: Rafael J. Wysocki, linux-pm@vger.kernel.org,
Linux Kernel Mailing List
On 15 October 2014 03:08, James Geboski <jgeboski@gmail.com> wrote:
> The intel_pstate driver only supports the performance and the powersave
> governors. With the performance governor ensuring the highest possible
> performance settings, userspace tools fail to make any lasting changes.
> In order to allow userspace tools to make modifications to the settings,
> the powersave governor must be in use. This makes having the powersave
> governor as the default convenient for systems where the intel_pstate
> driver is being employed. Having to enable expert mode in the kernel
> configuration is just a headache for such a trivial task.
>
> This patch applies to all kernel versions 2.6.38 or greater after the
> migration from CONFIG_EMBEDDED to CONFIG_EXPERT (6a108a14fa35). Most
> importantly, this applies to kernel versions 3.9 or greater when the
> intel_pstate driver was introduced.
>
> Signed-off-by: James Geboski <jgeboski@gmail.com>
> ---
> drivers/cpufreq/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index 3489f8f..73df7db 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -63,7 +63,6 @@ config CPU_FREQ_DEFAULT_GOV_PERFORMANCE
>
> config CPU_FREQ_DEFAULT_GOV_POWERSAVE
> bool "powersave"
> - depends on EXPERT
> select CPU_FREQ_GOV_POWERSAVE
> help
> Use the CPUFreq governor 'powersave' as default. This sets
This was the commit which introduced it:
commit 30d221db4439973076953e2ed44344fa92d1d09f
Author: Alessandro Guido <alessandro.guido@gmail.com>
Date: Fri Apr 18 13:31:13 2008 -0700
[CPUFREQ] allow use of the powersave governor as the default one
Allow use of the powersave cpufreq governor as the default one for EMBEDDED
configs.
Signed-off-by: Alessandro Guido <alessandro.guido@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Dave Jones <davej@redhat.com>
---
drivers/cpufreq/Kconfig | 9 +++++++++
drivers/cpufreq/cpufreq_powersave.c | 8 ++++++--
include/linux/cpufreq.h | 3 +++
3 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
index c159ae6..5f076ae 100644
--- a/drivers/cpufreq/Kconfig
+++ b/drivers/cpufreq/Kconfig
@@ -69,6 +69,15 @@ config CPU_FREQ_DEFAULT_GOV_PERFORMANCE
the frequency statically to the highest frequency supported by
the CPU.
+config CPU_FREQ_DEFAULT_GOV_POWERSAVE
+ bool "powersave"
+ depends on EMBEDDED
+ select CPU_FREQ_GOV_POWERSAVE
+ help
+ Use the CPUFreq governor 'powersave' as default. This sets
+ the frequency statically to the lowest frequency supported by
+ the CPU.
+
And I think it was wrong since ever, it should have been selected by
EMBEDDED instead
of a depends here.
For your patch:
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2] cpufreq: allow powersave governor as the default without expert mode
2014-10-14 21:38 [PATCH] cpufreq: allow powersave governor as the default without expert mode James Geboski
2014-10-16 8:15 ` Viresh Kumar
@ 2014-10-16 11:37 ` James Geboski
2014-10-30 21:18 ` Rafael J. Wysocki
1 sibling, 1 reply; 6+ messages in thread
From: James Geboski @ 2014-10-16 11:37 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar; +Cc: linux-pm, linux-kernel
The intel_pstate driver only supports the performance and the powersave
governors. With the performance governor ensuring the highest possible
performance settings, userspace tools fail to make any lasting changes.
In order to allow userspace tools to make modifications to the settings,
the powersave governor must be in use. This makes having the powersave
governor as the default convenient for systems where the intel_pstate
driver is being employed. Having to enable expert mode in the kernel
configuration is just a headache for such a trivial task.
This patch applies to all kernel versions 2.6.38 or greater after the
migration from CONFIG_EMBEDDED to CONFIG_EXPERT (6a108a14fa35). Most
importantly, this applies to kernel versions 3.9 or greater when the
intel_pstate driver was introduced.
Signed-off-by: James Geboski <jgeboski@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
---
ChangeLog v2:
- Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
index 3489f8f..73df7db 100644
--- a/drivers/cpufreq/Kconfig
+++ b/drivers/cpufreq/Kconfig
@@ -63,7 +63,6 @@ config CPU_FREQ_DEFAULT_GOV_PERFORMANCE
config CPU_FREQ_DEFAULT_GOV_POWERSAVE
bool "powersave"
- depends on EXPERT
select CPU_FREQ_GOV_POWERSAVE
help
Use the CPUFreq governor 'powersave' as default. This sets
--
2.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] cpufreq: allow powersave governor as the default without expert mode
2014-10-16 11:37 ` [PATCH v2] " James Geboski
@ 2014-10-30 21:18 ` Rafael J. Wysocki
2014-10-31 6:15 ` Dirk Brandewie
0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2014-10-30 21:18 UTC (permalink / raw)
To: James Geboski, 'Dirk Brandewie'
Cc: Viresh Kumar, linux-pm, linux-kernel, 'Dirk Brandewie'
On Thursday, October 16, 2014 07:37:11 AM James Geboski wrote:
> The intel_pstate driver only supports the performance and the powersave
> governors. With the performance governor ensuring the highest possible
> performance settings, userspace tools fail to make any lasting changes.
> In order to allow userspace tools to make modifications to the settings,
> the powersave governor must be in use. This makes having the powersave
> governor as the default convenient for systems where the intel_pstate
> driver is being employed. Having to enable expert mode in the kernel
> configuration is just a headache for such a trivial task.
>
> This patch applies to all kernel versions 2.6.38 or greater after the
> migration from CONFIG_EMBEDDED to CONFIG_EXPERT (6a108a14fa35). Most
> importantly, this applies to kernel versions 3.9 or greater when the
> intel_pstate driver was introduced.
>
> Signed-off-by: James Geboski <jgeboski@gmail.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Dirk, any objections?
> ---
> ChangeLog v2:
> - Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpufreq/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index 3489f8f..73df7db 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -63,7 +63,6 @@ config CPU_FREQ_DEFAULT_GOV_PERFORMANCE
>
> config CPU_FREQ_DEFAULT_GOV_POWERSAVE
> bool "powersave"
> - depends on EXPERT
> select CPU_FREQ_GOV_POWERSAVE
> help
> Use the CPUFreq governor 'powersave' as default. This sets
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] cpufreq: allow powersave governor as the default without expert mode
2014-10-30 21:18 ` Rafael J. Wysocki
@ 2014-10-31 6:15 ` Dirk Brandewie
2014-11-08 1:38 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Dirk Brandewie @ 2014-10-31 6:15 UTC (permalink / raw)
To: Rafael J. Wysocki, James Geboski
Cc: dirk.j.brandewie, Viresh Kumar, linux-pm, linux-kernel,
'Dirk Brandewie'
On 10/30/2014 02:18 PM, Rafael J. Wysocki wrote:
> On Thursday, October 16, 2014 07:37:11 AM James Geboski wrote:
>> The intel_pstate driver only supports the performance and the powersave
>> governors. With the performance governor ensuring the highest possible
>> performance settings, userspace tools fail to make any lasting changes.
>> In order to allow userspace tools to make modifications to the settings,
>> the powersave governor must be in use. This makes having the powersave
>> governor as the default convenient for systems where the intel_pstate
>> driver is being employed. Having to enable expert mode in the kernel
>> configuration is just a headache for such a trivial task.
>>
>> This patch applies to all kernel versions 2.6.38 or greater after the
>> migration from CONFIG_EMBEDDED to CONFIG_EXPERT (6a108a14fa35). Most
>> importantly, this applies to kernel versions 3.9 or greater when the
>> intel_pstate driver was introduced.
>>
>> Signed-off-by: James Geboski <jgeboski@gmail.com>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Dirk, any objections?
No objection.
>
>> ---
>> ChangeLog v2:
>> - Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>> ---
>> drivers/cpufreq/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
>> index 3489f8f..73df7db 100644
>> --- a/drivers/cpufreq/Kconfig
>> +++ b/drivers/cpufreq/Kconfig
>> @@ -63,7 +63,6 @@ config CPU_FREQ_DEFAULT_GOV_PERFORMANCE
>>
>> config CPU_FREQ_DEFAULT_GOV_POWERSAVE
>> bool "powersave"
>> - depends on EXPERT
>> select CPU_FREQ_GOV_POWERSAVE
>> help
>> Use the CPUFreq governor 'powersave' as default. This sets
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] cpufreq: allow powersave governor as the default without expert mode
2014-10-31 6:15 ` Dirk Brandewie
@ 2014-11-08 1:38 ` Rafael J. Wysocki
0 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2014-11-08 1:38 UTC (permalink / raw)
To: Dirk Brandewie
Cc: James Geboski, dirk.j.brandewie, Viresh Kumar, linux-pm,
linux-kernel
On Thursday, October 30, 2014 11:15:09 PM Dirk Brandewie wrote:
> On 10/30/2014 02:18 PM, Rafael J. Wysocki wrote:
> > On Thursday, October 16, 2014 07:37:11 AM James Geboski wrote:
> >> The intel_pstate driver only supports the performance and the powersave
> >> governors. With the performance governor ensuring the highest possible
> >> performance settings, userspace tools fail to make any lasting changes.
> >> In order to allow userspace tools to make modifications to the settings,
> >> the powersave governor must be in use. This makes having the powersave
> >> governor as the default convenient for systems where the intel_pstate
> >> driver is being employed. Having to enable expert mode in the kernel
> >> configuration is just a headache for such a trivial task.
> >>
> >> This patch applies to all kernel versions 2.6.38 or greater after the
> >> migration from CONFIG_EMBEDDED to CONFIG_EXPERT (6a108a14fa35). Most
> >> importantly, this applies to kernel versions 3.9 or greater when the
> >> intel_pstate driver was introduced.
> >>
> >> Signed-off-by: James Geboski <jgeboski@gmail.com>
> >> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
> > Dirk, any objections?
>
> No objection.
OK, patch queued up for 3.19-rc1, thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-11-08 1:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-14 21:38 [PATCH] cpufreq: allow powersave governor as the default without expert mode James Geboski
2014-10-16 8:15 ` Viresh Kumar
2014-10-16 11:37 ` [PATCH v2] " James Geboski
2014-10-30 21:18 ` Rafael J. Wysocki
2014-10-31 6:15 ` Dirk Brandewie
2014-11-08 1:38 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).