From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH 02/12] drivers: mfd: Add support for Exynos PMU driver Date: Wed, 05 Nov 2014 14:47:36 +0100 Message-ID: <545A2A78.5000901@samsung.com> References: <1414986790-11940-1-git-send-email-amit.daniel@samsung.com> <1414986790-11940-3-git-send-email-amit.daniel@samsung.com> <20141103152604.GA10544@x1> <002601cff7de$0f8db7e0$2ea927a0$@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:20839 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751198AbaKENrq (ORCPT ); Wed, 5 Nov 2014 08:47:46 -0500 In-reply-to: <002601cff7de$0f8db7e0$2ea927a0$@samsung.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Pankaj Dubey , 'Lee Jones' Cc: 'Amit Daniel Kachhap' , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, kgene.kim@samsung.com, 'Sangbeom Kim' , 'Samuel Ortiz' On 04/11/14 04:18, Pankaj Dubey wrote: > 2: Since PM domain relies on PMU registers and does not have > its own DT binding, MFD client and MFD device > is most suitable for making this kind of platform drivers. We have DT binding for the Exynos power domains: Documentation/devicetree/bindings/arm/exynos/power_domain.txt In fact the IO memory regions used in the power domain bindings fall within the (sparse) PMU registers region. There is also DT binding for the PMU subsystem: Documentation/devicetree/bindings/arm/samsung/pmu.txt I guess a platform device driver in drivers/power would be a better fit than drivers/mfd. I doubt introducing an mfd driver now makes much sense, we have already DT bindings for PHYs, the power domains, etc. -- Thanks, Sylwester