From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Ulf Hansson <ulf.hansson@linaro.org>,
Alan Stern <stern@rowland.harvard.edu>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Kevin Hilman <khilman@kernel.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] PM / Domains: Fix initial default state of the need_restore flag
Date: Thu, 13 Nov 2014 22:22:49 +0200 [thread overview]
Message-ID: <54651319.8010807@ti.com> (raw)
In-Reply-To: <20141113191129.GP3815@sirena.org.uk>
Hi Mark,
On 11/13/2014 09:11 PM, Mark Brown wrote:
> On Thu, Nov 13, 2014 at 09:07:43PM +0200, Grygorii Strashko wrote:
>> On 11/13/2014 07:54 PM, Mark Brown wrote:
>
>>> No, it doesn't - probe() leaves the device powered (you can see the
>>> driver interacting with the device before it enables runtime PM).
>
>> What I've found there is:
>> arizona_dev_init()
>> |- arizona_clk32k_enable()
>> |-pm_runtime_get_sync() if arizona->pdata.clk32k_src == ARIZONA_32KZ_MCLK1
|-arizona_runtime_resume() if dev->driver.pm == arizona_pm_ops
>
>> so it's added as "may rely"
>
> No, that's adding a reference to stop it power down under runtime PM -
> if runtime PM is inactive it will have no effect.
>
NP. You know better - it's not about something wrong. It's just small
list of drivers where .runtime_resume() is called or may be called from
.probe() (just as an example) :)
regards,
-grygorii
next prev parent reply other threads:[~2014-11-13 20:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 13:27 [PATCH] PM / Domains: Fix initial default state of the need_restore flag Ulf Hansson
2014-11-07 18:52 ` Sylwester Nawrocki
2014-11-07 19:47 ` Kevin Hilman
2014-11-07 21:57 ` Dmitry Torokhov
2014-11-07 22:26 ` Kevin Hilman
2014-11-10 15:18 ` Ulf Hansson
2014-11-10 18:32 ` Dmitry Torokhov
2014-11-10 19:39 ` Mark Brown
2014-11-10 20:33 ` Dmitry Torokhov
2014-11-13 2:52 ` Rafael J. Wysocki
2014-11-13 16:40 ` Ulf Hansson
2014-11-13 19:14 ` Grygorii Strashko
2014-11-13 21:59 ` Ulf Hansson
2014-11-13 17:50 ` Grygorii Strashko
2014-11-13 17:54 ` Mark Brown
2014-11-13 19:07 ` Grygorii Strashko
2014-11-13 19:11 ` Mark Brown
2014-11-13 20:22 ` Grygorii Strashko [this message]
2014-11-14 19:16 ` Kevin Hilman
2014-11-14 23:45 ` Rafael J. Wysocki
2014-11-08 0:58 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2014-11-10 9:24 Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54651319.8010807@ti.com \
--to=grygorii.strashko@ti.com \
--cc=broonie@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=s.nawrocki@samsung.com \
--cc=stern@rowland.harvard.edu \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).