linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ethan zhao <ethan.zhao@oracle.com>
To: Ethan Zhao <ethan.zhao@oracle.com>
Cc: dirk.j.brandewie@intel.com, linda.knippers@hp.com,
	viresh.kumar@linaro.org, rjw@rjwysocki.net, corbet@lwn.net,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, ethan.kernel@gmail.com,
	Alexey Kodanev <alexey.kodanev@oracle.com>
Subject: Re: [PATCH 2/2 V7] intel_pstate: add kernel parameter to force loading on Sun X86 servers.
Date: Thu, 04 Dec 2014 10:22:14 +0800	[thread overview]
Message-ID: <547FC556.8010301@oracle.com> (raw)
In-Reply-To: <1417658851-8729-1-git-send-email-ethan.zhao@oracle.com>

Alexey has tested this patch on Lenovo machines. so

Tested-by: Alexey Kodanev <alexey.kodanev@oracle.com>

On 2014/12/4 10:07, Ethan Zhao wrote:
> To force loading on Oracle Sun X86 servers, provide one kernel command line
> parameter
>
>    intel_pstate = ora_force
>
> For those who be aware of the risk of no power capping capabily working and
> try to get better performance with this driver.
>
> Signed-off-by: Ethan Zhao <ethan.zhao@oracle.com>
> ---
>   v2: change to hardware vendor specific naming parameter.
>   v4: refine code and doc.
>   v5&v6: fix a typo in doc.
>   v7: change enum PCC to PPC.
>
>   Documentation/kernel-parameters.txt | 5 +++++
>   drivers/cpufreq/intel_pstate.c      | 6 +++++-
>   2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> index 479f332..7d0983e 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -1446,6 +1446,11 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
>   		       disable
>   		         Do not enable intel_pstate as the default
>   		         scaling driver for the supported processors
> +		       ora_force
> +			 Force loading intel_pstate on Oracle Sun Servers(X86).
> +			 only for those who be aware of the risk of no power capping
> +			 capability working and try to get better performance with this
> +			 driver.
>   
>   	intremap=	[X86-64, Intel-IOMMU]
>   			on	enable Interrupt Remapping (default)
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 1bb62ca..2654e13 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -866,6 +866,7 @@ static struct cpufreq_driver intel_pstate_driver = {
>   };
>   
>   static int __initdata no_load;
> +static unsigned int  ora_force;
>   
>   static int intel_pstate_msrs_not_valid(void)
>   {
> @@ -1003,7 +1004,8 @@ static bool intel_pstate_platform_pwr_mgmt_exists(void)
>   			case PSS:
>   				return intel_pstate_no_acpi_pss();
>   			case PPC:
> -				return intel_pstate_has_acpi_ppc();
> +				return intel_pstate_has_acpi_ppc() &&
> +					(!ora_force);
>   			}
>   	}
>   
> @@ -1078,6 +1080,8 @@ static int __init intel_pstate_setup(char *str)
>   
>   	if (!strcmp(str, "disable"))
>   		no_load = 1;
> +	if (!strcmp(str, "ora_force"))
> +		ora_force = 1;
>   	return 0;
>   }
>   early_param("intel_pstate", intel_pstate_setup);


  reply	other threads:[~2014-12-04  2:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04  2:07 [PATCH 2/2 V7] intel_pstate: add kernel parameter to force loading on Sun X86 servers Ethan Zhao
2014-12-04  2:22 ` ethan zhao [this message]
2014-12-04 22:10 ` Rafael J. Wysocki
2014-12-04 22:38   ` Kristen Carlson Accardi
2014-12-04 23:03     ` Linda Knippers
2014-12-05  2:05       ` Rafael J. Wysocki
2014-12-05  3:50         ` Linda Knippers
2014-12-05  3:38       ` ethan zhao
2014-12-05  4:56         ` Linda Knippers
2014-12-05  5:52           ` ethan zhao
2014-12-05  2:23     ` ethan zhao
2014-12-05  2:14   ` ethan zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547FC556.8010301@oracle.com \
    --to=ethan.zhao@oracle.com \
    --cc=alexey.kodanev@oracle.com \
    --cc=corbet@lwn.net \
    --cc=dirk.j.brandewie@intel.com \
    --cc=ethan.kernel@gmail.com \
    --cc=linda.knippers@hp.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).