From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v7 08/11] arm/arm64: Unexport restart handlers Date: Thu, 04 Dec 2014 06:51:49 -0800 Message-ID: <54807505.2000406@roeck-us.net> References: <1408495538-27480-1-git-send-email-linux@roeck-us.net> <1408495538-27480-9-git-send-email-linux@roeck-us.net> <54806F2A.7070107@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Russell King , Wim Van Sebroeck , Catalin Marinas , Maxime Ripard , Andrew Morton , "linux-samsung-soc@vger.kernel.org" , Linux Watchdog Mailing List , Arnd Bergmann , Linux PM list , Dmitry Eremin-Solenikov , Tomasz Figa , Randy Dunlap , Will Deacon , "linux-kernel@vger.kernel.org" , Steven Rostedt , Jonas Jensen , "linux-doc@vger.kernel.org" , David Woodhouse , Ingo Molnar , linux-arm-kernel@lists.infradead.o List-Id: linux-pm@vger.kernel.org On 12/04/2014 06:44 AM, Geert Uytterhoeven wrote: > Hi G=C3=BCnther, > > On Thu, Dec 4, 2014 at 3:26 PM, Guenter Roeck wr= ote: >> On 12/04/2014 05:36 AM, Geert Uytterhoeven wrote: >>> On Wed, Aug 20, 2014 at 2:45 AM, Guenter Roeck = wrote: >>>> Implementing a restart handler in a module don't make sense >>>> as there would be no guarantee that the module is loaded when >>>> a restart is needed. Unexport arm_pm_restart to ensure that >>>> no one gets the idea to do it anyway. >>> >>> Why not? I was just going to do that, but I got greeted by: >> >> Because you should register a restart handler instead, like the othe= r >> drivers in the same directory now do. > > That's a different thing. "there would be no guarantee that the modul= e is > loaded when a restart is needed" is also valid for restart handlers..= =2E > Not really, because you are supposed to unregister the restart handler on unload. Sure, you can instead clear arm_pm_reastart and leave the sy= stem with no means to restart ... Guenter >>> ERROR: "arm_pm_restart" [drivers/power/reset/rmobile-reset.ko] unde= fined! >>> >>> So now we have to make sure all reset drivers for a zillion differe= nt >>> hardware devices are builtin, and can't be modular? >>> >> No. All those drivers need to do is to register a restart handler us= ing >> the API provided in the patch series. >> >> Ultimately all restart handlers should do that and arm_pm_restart sh= ould >> go away entirely. That was the point of the patch series. > > Good. That's what I'm doing right know ;-) > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linu= x-m68k.org > > In personal conversations with technical people, I call myself a hack= er. But > when I'm talking to journalists I just say "programmer" or something = like that. > -- Linus Torvalds >