From: Prarit Bhargava <prarit@redhat.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 00/13] cpufreq: stats: cleanups
Date: Tue, 30 Dec 2014 09:56:13 -0500 [thread overview]
Message-ID: <54A2BD0D.5010203@redhat.com> (raw)
In-Reply-To: <CAKohpo=scqNCuXDF4E29fnYEJZ3ytwomBoJ5S20WrMD4PL0b9A@mail.gmail.com>
On 12/28/2014 11:41 PM, Viresh Kumar wrote:
> On 19 December 2014 at 07:45, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>> On Thursday, December 18, 2014 05:30:17 PM Viresh Kumar wrote:
>>> Hi Rafael,
>>>
>>> I finally started looking at how to make cpufreq-core somewhat less complex with
>>> respect to locking, its state machine, etc..
>>>
>>> The first thing I had to get into was cpufreq-stats and so this series. Mostly
>>> cleanups to make things better..
>>>
>>> Please see if they make any sense at all.
>>>
>>> I know we are at Merge window right now and you wouldn't apply it even to
>>> linux-next. So, if they look fine, please don't hesitate in dropping a mail to
>>> confirm they look fine, so that I can send the next set of cleanups atleast for
>>> reviews. We can get these applied one by one then, once we are a bit confident
>>> of them.
>>
>> Well, the timing is pretty bad for various reasons. For one, this isn't 3.19
>> material, so I'm not even going to look at it tomorrow and I'm officially on
>> vacation from Monday onward pretty much through the first half of January.
>>
>> If I have some time and really nothing else to do, I'll have a look at it, but
>> I can't promise anything.
>>
>> It would be good if you could ask poeple to have a look at it and give comments
>> in the meantime.
>
> Prarit, any more comments about this series ?
>
> Latest stuff is here:
> git://git.linaro.org/people/viresh.kumar/linux.git cpufreq/stats/cleanups
Hey Viresh, seems fine to me. I do want to again point out the issue with the
sysfs removal but fixing that type of issue is out-of-scope for this patchset.
Reviewed-by: Prarit Bhargava <prarit@redhat.com>
P.
>
> --
> viresh
>
prev parent reply other threads:[~2014-12-30 14:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 12:00 [PATCH 00/13] cpufreq: stats: cleanups Viresh Kumar
2014-12-18 12:00 ` [PATCH 01/13] cpufreq: stats: don't break strings into multiple lines Viresh Kumar
2014-12-18 12:00 ` [PATCH 02/13] cpufreq: stats: return -EEXIST when stats are already allocated Viresh Kumar
2014-12-18 12:00 ` [PATCH 03/13] cpufreq: stats: don't check for freq table while freeing stats Viresh Kumar
2014-12-18 12:00 ` [PATCH 04/13] cpufreq: stats: pass 'stat' to cpufreq_stats_update() Viresh Kumar
2014-12-18 12:00 ` [PATCH 05/13] cpufreq: stats: get rid of per-cpu cpufreq_stats_table Viresh Kumar
2014-12-18 12:00 ` [PATCH 06/13] cpufreq: Remove (now) unused 'last_cpu' from struct cpufreq_policy Viresh Kumar
2014-12-18 12:00 ` [PATCH 07/13] cpufreq: stats: remove cpufreq_stats_update_policy_cpu() Viresh Kumar
2014-12-18 12:00 ` [PATCH 08/13] cpufreq: remove CPUFREQ_UPDATE_POLICY_CPU notifications Viresh Kumar
2014-12-18 12:00 ` [PATCH 09/13] cpufreq: stats: create sysfs group once we are ready Viresh Kumar
2014-12-18 12:00 ` [PATCH 10/13] cpufreq: stats: don't update stats from show_trans_table() Viresh Kumar
2014-12-18 12:00 ` [PATCH 11/13] cpufreq: stats: don't update stats on false notifiers Viresh Kumar
2014-12-18 12:00 ` [PATCH 12/13] cpufreq: stats: Fix locking Viresh Kumar
2014-12-23 6:06 ` Viresh Kumar
2014-12-23 10:47 ` Prarit Bhargava
2014-12-23 10:55 ` Viresh Kumar
2014-12-24 19:01 ` Prarit Bhargava
2014-12-18 12:00 ` [PATCH 13/13] cpufreq: stats: call cpufreq_stats_update() with locks held Viresh Kumar
2014-12-19 2:15 ` [PATCH 00/13] cpufreq: stats: cleanups Rafael J. Wysocki
2014-12-29 4:41 ` Viresh Kumar
2014-12-30 14:56 ` Prarit Bhargava [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A2BD0D.5010203@redhat.com \
--to=prarit@redhat.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).